From mboxrd@z Thu Jan 1 00:00:00 1970 Date: Fri, 8 Jun 2012 17:28:42 -0700 From: Andrew Morton To: Linus Torvalds Subject: Re: [RFC, PATCH, RESEND] fs: push rcu_barrier() from deactivate_locked_super() to filesystems Message-Id: <20120608172842.9826b5cd.akpm@linux-foundation.org> In-Reply-To: References: <1339191663-17693-1-git-send-email-kirill.shutemov@linux.intel.com> <20120608150253.e42464a6.akpm@linux-foundation.org> <20120608221446.GA18250@otc-wbsnb-06> <20120608152550.258d6a30.akpm@linux-foundation.org> <20120608222734.GT30000@ZenIV.linux.org.uk> <20120608153120.b722d7c3.akpm@linux-foundation.org> <20120608233127.GB18981@otc-wbsnb-06> <20120608163751.7a8ec2bc.akpm@linux-foundation.org> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: jfs-discussion@lists.sourceforge.net, "Dmitry V. Levin" , linux-mtd@lists.infradead.org, ocfs2-devel@oss.oracle.com, linux-afs@lists.infradead.org, codalist@telemann.coda.cs.cmu.edu, linux-cifs@vger.kernel.org, linux-nilfs@vger.kernel.org, Boaz Harrosh , v9fs-developer@lists.sourceforge.net, linux-ext4@vger.kernel.org, Nick Piggin , fuse-devel@lists.sourceforge.net, Tao Ma , ecryptfs@vger.kernel.org, reiserfs-devel@vger.kernel.org, Al Viro , ceph-devel@vger.kernel.org, linux-nfs@vger.kernel.org, linux-ntfs-dev@lists.sourceforge.net, samba-technical@lists.samba.org, linux-kernel@vger.kernel.org, logfs@logfs.org, "Kirill A. Shutemov" , linux-fsdevel@vger.kernel.org, linux-btrfs@vger.kernel.org, osd-dev@open-osd.org List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Fri, 8 Jun 2012 16:46:47 -0700 Linus Torvalds wrote: > Of course, if you just mean having a VFS wrapper that does > > static void vfs_inode_kmem_cache_destroy(struct kmem_cache *cachep) > { > rcu_barrier(); > kmem_cache_destroy(cachep); > } > > then we could do that. Not much better than what Kirill's patch did, > but at least we could have that comment in just one single place. That's conceptually what I meant. But it has the problem that new and out-of-tree filesystems might forget to do it. Which is why I suggest adding a kmem_cache* argument to unregister_filesystem() for this. It's a bit awkward, and the fs can pass in NULL if it knows what it's doing. But it's reliable.