From mboxrd@z Thu Jan 1 00:00:00 1970 Date: Fri, 8 Jun 2012 23:25:33 +0100 From: Al Viro To: Linus Torvalds Subject: Re: [RFC, PATCH] fs: push rcu_barrier() from deactivate_locked_super() to filesystems Message-ID: <20120608222533.GS30000@ZenIV.linux.org.uk> References: <1339191663-17693-1-git-send-email-kirill.shutemov@linux.intel.com> <20120608220049.GA18024@otc-wbsnb-06> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: Al Viro Cc: jfs-discussion@lists.sourceforge.net, "Dmitry V. Levin" , linux-mtd@lists.infradead.org, ocfs2-devel@oss.oracle.com, linux-afs@lists.infradead.org, linux-cifs@vger.kernel.org, linux-nilfs@vger.kernel.org, codalist@coda.cs.cmu.edu, Boaz Harrosh , v9fs-developer@lists.sourceforge.net, linux-ext4@vger.kernel.org, Nick Piggin , fuse-devel@lists.sourceforge.net, Tao Ma , ecryptfs@vger.kernel.org, reiserfs-devel@vger.kernel.org, osd-dev@open-osd.org, ceph-devel@vger.kernel.org, linux-nfs@vger.kernel.org, linux-ntfs-dev@lists.sourceforge.net, samba-technical@lists.samba.org, linux-kernel@vger.kernel.org, logfs@logfs.org, "Kirill A. Shutemov" , linux-fsdevel@vger.kernel.org, Andrew Morton , linux-btrfs@vger.kernel.org List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Fri, Jun 08, 2012 at 03:06:20PM -0700, Linus Torvalds wrote: > .. hmm. I think you may be right. Even if we do move it up, we > probably shouldn't use it. > > We don't even want SLAB_DESTROY_BY_RCU, since we do the delayed RCU > free for other reasons anyway, so it would duplicate the RCU delaying > and cause problems. I forgot about that little complication. > > We could have a separate "RCU_BARRIER_ON_DESTROY" thing, but that's > just silly too. Why not make that rcu_barrier() in there unconditional? Where are we creating/destroying caches often enough for that to become a problem?