From: Sascha Hauer <s.hauer@pengutronix.de>
To: linux-mtd@lists.infradead.org
Cc: Subodh Nijsure <snijsure@grid-net.com>,
Artem Bityutskiy <dedekind1@gmail.com>,
stable@vger.kernel.org, Huang Shijie <b32955@freescale.com>,
kernel@pengutronix.de, Brian Norris <computersforpeace@gmail.com>
Subject: Re: [PATCH] mtd gpmi-nand: Fix read page when reading to vmalloced area
Date: Wed, 27 Jun 2012 08:24:23 +0200 [thread overview]
Message-ID: <20120627062423.GD24458@pengutronix.de> (raw)
In-Reply-To: <1340724377-22279-1-git-send-email-s.hauer@pengutronix.de>
On Tue, Jun 26, 2012 at 05:26:16PM +0200, Sascha Hauer wrote:
> The gpmi-nand driver uses virt_addr_valid() to check whether a buffer
> is suitable for dma. If it's not, a driver allocated buffer is used
> instead. Then after a page read the driver allocated buffer must be
> copied to the user supplied buffer. This does not happen since:
>
> commit 7725cc85932bd02dd12c23108e0ef748c551ccba
> Author: Brian Norris <computersforpeace@gmail.com>
> Date: Wed May 2 10:15:02 2012 -0700
>
> mtd: gpmi-nand: utilize oob_requested parameter
>
> Don't read OOB if the caller didn't request it.
>
> Signed-off-by: Brian Norris <computersforpeace@gmail.com>
> Acked-by: Huang Shijie <b32955@freescale.com>
> Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
> Signed-off-by: David Woodhouse <David.Woodhouse@intel.com>
>
> This patch fixes this. The bug is encountered with UBI which uses a vmalloced
> buffer for the volume table.
>
> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
> Cc: stable@vger.kernel.org
Sorry, please remove the stable tag, this bug was introduced in the last
merge window.
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
next prev parent reply other threads:[~2012-06-27 6:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-26 15:26 [PATCH] mtd gpmi-nand: Fix read page when reading to vmalloced area Sascha Hauer
2012-06-27 2:18 ` Huang Shijie
2012-06-27 6:24 ` Sascha Hauer [this message]
2012-06-27 22:07 ` Subodh Nijsure
2012-06-29 7:10 ` Artem Bityutskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120627062423.GD24458@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=b32955@freescale.com \
--cc=computersforpeace@gmail.com \
--cc=dedekind1@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-mtd@lists.infradead.org \
--cc=snijsure@grid-net.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox