From: Sascha Hauer <s.hauer@pengutronix.de>
To: Fabio Estevam <festevam@gmail.com>
Cc: Fabio Estevam <fabio.estevam@freescale.com>,
artem.bityutskiy@linux.intel.com, linux-mtd@lists.infradead.org,
kernel@pengutronix.de, shawn.guo@linaro.org, dwmw2@infradead.org
Subject: Re: [PATCH] mtd: mxc_nand: Select the driver via ARCH_MXC
Date: Wed, 4 Jul 2012 08:59:14 +0200 [thread overview]
Message-ID: <20120704065914.GG2698@pengutronix.de> (raw)
In-Reply-To: <1341266419-21321-1-git-send-email-festevam@gmail.com>
On Mon, Jul 02, 2012 at 07:00:19PM -0300, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@freescale.com>
>
> With device tree support in place, we should not use IMX_HAVE_PLATFORM_MXC_NAND
> as a dependency for selecting the mxc_nand driver.
>
> Use ARCH_MXC symbol instead, so that the driver can be even selected when a single device-tree
> machine is selected.
>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
Simple solution for a problem. I don't want to add even more
dependencies. Also I think being able to compile in a driver
even if it has no possible users in the tree does not hurt,
so:
Acked-by: Sascha Hauer <s.hauer@pengutronix.de>
> ---
> drivers/mtd/nand/Kconfig | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/mtd/nand/Kconfig b/drivers/mtd/nand/Kconfig
> index de69978..d2a0db1 100644
> --- a/drivers/mtd/nand/Kconfig
> +++ b/drivers/mtd/nand/Kconfig
> @@ -521,7 +521,7 @@ config MTD_NAND_MPC5121_NFC
>
> config MTD_NAND_MXC
> tristate "MXC NAND support"
> - depends on IMX_HAVE_PLATFORM_MXC_NAND
> + depends on ARCH_MXC
> help
> This enables the driver for the NAND flash controller on the
> MXC processors.
> --
> 1.7.1
>
>
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
next prev parent reply other threads:[~2012-07-04 6:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-02 22:00 [PATCH] mtd: mxc_nand: Select the driver via ARCH_MXC Fabio Estevam
2012-07-03 7:03 ` Uwe Kleine-König
2012-07-04 1:02 ` Fabio Estevam
2012-07-04 6:59 ` Sascha Hauer [this message]
2012-07-08 19:53 ` Uwe Kleine-König
2012-07-16 7:29 ` Artem Bityutskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120704065914.GG2698@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=artem.bityutskiy@linux.intel.com \
--cc=dwmw2@infradead.org \
--cc=fabio.estevam@freescale.com \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-mtd@lists.infradead.org \
--cc=shawn.guo@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox