From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mail-out.m-online.net ([212.18.0.9])
 by merlin.infradead.org with esmtps (Exim 4.76 #1 (Red Hat Linux))
 id 1SpdSe-0002A6-Dn
 for linux-mtd@lists.infradead.org; Fri, 13 Jul 2012 10:51:04 +0000
From: Marek Vasut <marex@denx.de>
To: Huang Shijie <b32955@freescale.com>
Subject: Re: [PATCH] mtd: add a new macro about the subpage write
Date: Fri, 13 Jul 2012 12:35:43 +0200
References: <1341293533-2214-1-git-send-email-b32955@freescale.com>
 <CAN8TOE-59M6UCW91QS0_ZKzBO-HUyXrUXcmW3avOd8=4CmE4Fg@mail.gmail.com>
 <4FFD27A1.9000008@freescale.com>
In-Reply-To: <4FFD27A1.9000008@freescale.com>
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="us-ascii"
Content-Transfer-Encoding: 7bit
Message-Id: <201207131235.43633.marex@denx.de>
Cc: dedekind1@gmail.com, Jan Weitzel <j.weitzel@phytec.de>,
 linux-mtd@lists.infradead.org, Scott Wood <scottwood@freescale.com>,
 Brian Norris <computersforpeace@gmail.com>, Huang Shijie <shijie8@gmail.com>
List-Id: Linux MTD discussion mailing list <linux-mtd.lists.infradead.org>
List-Unsubscribe: <http://lists.infradead.org/mailman/options/linux-mtd>,
 <mailto:linux-mtd-request@lists.infradead.org?subject=unsubscribe>
List-Archive: <http://lists.infradead.org/pipermail/linux-mtd/>
List-Post: <mailto:linux-mtd@lists.infradead.org>
List-Help: <mailto:linux-mtd-request@lists.infradead.org?subject=help>
List-Subscribe: <http://lists.infradead.org/mailman/listinfo/linux-mtd>,
 <mailto:linux-mtd-request@lists.infradead.org?subject=subscribe>

Dear Huang Shijie,

> Hi Brian:
> > Wood [1]; I don't see a good reason not to just kill the
> > NAND_CHIPOPTIONS_MSK instead of adding more flags. As long as we
> > perform a few sanity tests, I think it'd be safe.
> 
> I think it's more clear in logic to add this new macro:
>     The NAND_NO_SUBPAGE_WRITE can be used only by the MLC nands which do
> no support the subpage write;
>     The NAND_CONTROLLER_NO_SUBPAGE_WRITE only used by the nand
> controller such as gpmi nand.

It's not clearer at all. It's just more error-prone.

> But I will be happy if you submit a patch to fix this issue by removing
> the NAND_CHIPOPTIONS_MSK.

I'd be happy if the GPMI NAND driver was properly fixed, 6 months after 
reporting this bug, which is quite critical as UBI doesn't work because of that 
and it's being silently ignored.

> thanks
> Huang Shijie

Best regards,
Marek Vasut