From: Marek Vasut <marex@denx.de>
To: Huang Shijie <shijie8@gmail.com>
Cc: dedekind1@gmail.com, Jan Weitzel <j.weitzel@phytec.de>,
Huang Shijie <b32955@freescale.com>,
linux-mtd@lists.infradead.org,
Scott Wood <scottwood@freescale.com>,
Brian Norris <computersforpeace@gmail.com>
Subject: Re: [PATCH] mtd: add a new macro about the subpage write
Date: Fri, 13 Jul 2012 17:40:10 +0200 [thread overview]
Message-ID: <201207131740.10668.marex@denx.de> (raw)
In-Reply-To: <CAMiH66GzmAJV+GfeuaigakiAFPB2gvzQaLd47yLcrz9dht3pLA@mail.gmail.com>
Dear Huang Shijie,
> On Fri, Jul 13, 2012 at 6:35 AM, Marek Vasut <marex@denx.de> wrote:
> > Dear Huang Shijie,
> >
> >> Hi Brian:
> >> > Wood [1]; I don't see a good reason not to just kill the
> >> > NAND_CHIPOPTIONS_MSK instead of adding more flags. As long as we
> >> > perform a few sanity tests, I think it'd be safe.
> >>
> >> I think it's more clear in logic to add this new macro:
> >> The NAND_NO_SUBPAGE_WRITE can be used only by the MLC nands which do
> >>
> >> no support the subpage write;
> >>
> >> The NAND_CONTROLLER_NO_SUBPAGE_WRITE only used by the nand
> >>
> >> controller such as gpmi nand.
> >
> > It's not clearer at all. It's just more error-prone.
>
> ok, thanks. But I do not how to fix it now. I hope some one could give a
> patch.
Why not remove the mask?
> Best Regards
> Huang Shijie
>
> >> But I will be happy if you submit a patch to fix this issue by removing
> >> the NAND_CHIPOPTIONS_MSK.
> >
> > I'd be happy if the GPMI NAND driver was properly fixed, 6 months after
> > reporting this bug, which is quite critical as UBI doesn't work because
> > of that and it's being silently ignored.
> >
> >> thanks
> >> Huang Shijie
> >
> > Best regards,
> > Marek Vasut
Best regards,
Marek Vasut
next prev parent reply other threads:[~2012-07-13 15:40 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-03 5:32 [PATCH] mtd: add a new macro about the subpage write Huang Shijie
2012-07-11 6:07 ` Brian Norris
2012-07-11 7:13 ` Huang Shijie
2012-07-13 10:35 ` Marek Vasut
2012-07-13 14:00 ` Huang Shijie
2012-07-13 15:40 ` Marek Vasut [this message]
2012-07-13 16:08 ` Huang Shijie
2012-07-13 16:28 ` Marek Vasut
2012-07-13 16:29 ` Scott Wood
2012-07-13 16:53 ` Marek Vasut
2012-07-13 17:02 ` Brian Norris
2012-07-13 17:10 ` Marek Vasut
2012-07-13 17:35 ` [PATCH] mtd: add a new macro about the subpage write (REPORT SPAM) William F.
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201207131740.10668.marex@denx.de \
--to=marex@denx.de \
--cc=b32955@freescale.com \
--cc=computersforpeace@gmail.com \
--cc=dedekind1@gmail.com \
--cc=j.weitzel@phytec.de \
--cc=linux-mtd@lists.infradead.org \
--cc=scottwood@freescale.com \
--cc=shijie8@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox