From: Shmulik Ladkani <shmulik.ladkani@gmail.com>
To: Brian Norris <computersforpeace@gmail.com>
Cc: linux-mtd@lists.infradead.org,
David Woodhouse <dwmw2@infradead.org>,
Artem Bityutskiy <dedekind1@gmail.com>
Subject: Re: [PATCH] mtd: nand: Rename create_bbt()'s 'len' variable to 'numpages'
Date: Sat, 25 Aug 2012 11:32:29 +0300 [thread overview]
Message-ID: <20120825113229.0c28f460@halley> (raw)
In-Reply-To: <CAN8TOE8ato4XkhHerKBHL_FHr+36yH5F0sVqReZQtDDZTY6jig@mail.gmail.com>
On Fri, 24 Aug 2012 17:18:22 -0700 Brian Norris <computersforpeace@gmail.com> wrote:
> On Mon, Aug 20, 2012 at 6:29 AM, Shmulik Ladkani
> Thanks, this kind of fix is actually very helpful! It's kinda annoying
> that I always have to translate in my head the fact that 'len' means
> 'number of pages.'
Exactly.
It was triggered from reviewing some of the latest bbt patches; I was
summarizing on a _paper_: "len is numpages, scanlen is ... readlen is ..."
and I thought to myself, isn't this crazy?
So yes, naming is important ;-)
(BTW scanlen and readlen are annoying, too... but they don't have a
concise meaning)
Regards,
Shmulik
next prev parent reply other threads:[~2012-08-25 8:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-20 13:29 [PATCH] mtd: nand: Rename create_bbt()'s 'len' variable to 'numpages' Shmulik Ladkani
2012-08-25 0:18 ` Brian Norris
2012-08-25 8:32 ` Shmulik Ladkani [this message]
2012-09-22 18:54 ` Shmulik Ladkani
2012-09-23 12:02 ` Artem Bityutskiy
2012-09-23 14:38 ` Shmulik Ladkani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120825113229.0c28f460@halley \
--to=shmulik.ladkani@gmail.com \
--cc=computersforpeace@gmail.com \
--cc=dedekind1@gmail.com \
--cc=dwmw2@infradead.org \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).