From: Marek Vasut <marex@denx.de>
To: Fabio Estevam <festevam@gmail.com>
Cc: Fabio Estevam <fabio.estevam@freescale.com>,
artem.bityutskiy@linux.intel.com, linux-mtd@lists.infradead.org,
kernel@pengutronix.de, b32955@freescale.com
Subject: Re: [PATCH 1/2] mtd: gpmi-nand: Convert to platform driver
Date: Wed, 5 Sep 2012 21:23:54 +0200 [thread overview]
Message-ID: <201209052123.54695.marex@denx.de> (raw)
In-Reply-To: <CAOMZO5DD+6keJ6jkQL-AHzhdobG84=3H_r2HPOFR7apFgKYtYA@mail.gmail.com>
Dear Fabio Estevam,
> Hi Marek,
>
> On Wed, Sep 5, 2012 at 3:55 PM, Marek Vasut <marex@denx.de> wrote:
> > Dear Fabio Estevam,
> >
> >> From: Fabio Estevam <fabio.estevam@freescale.com>
> >>
> >> Using module_platform_driver() makes the code smaller and cleaner.
> >
> > You did not document the dev_info() etc. addition, dunno if it's
> > important or not.
>
> It is not an addition. I just moved "pr_info("driver registered.\n")"
> from gpmi_nand_init, (which is removed by this patch) to the probe
> function.
Ah, just noticed. I'd say drop it completely then, there's now value in this
print (or make it pr_debug() ). Besides, the init call was called only once if
compiled in / every time if built as a module. The probe call is done per GPMI
nand driver instance.
> Regards,
>
> Fabio Estevam
Best regards,
Marek Vasut
next prev parent reply other threads:[~2012-09-05 19:23 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-05 14:35 [PATCH 1/2] mtd: gpmi-nand: Convert to platform driver Fabio Estevam
2012-09-05 14:35 ` [PATCH 2/2] mtd: mxc_nand: " Fabio Estevam
2012-09-15 13:33 ` Fabio Estevam
2012-09-05 18:55 ` [PATCH 1/2] mtd: gpmi-nand: " Marek Vasut
2012-09-05 19:00 ` Fabio Estevam
2012-09-05 19:23 ` Marek Vasut [this message]
2012-09-05 19:51 ` Fabio Estevam
2012-09-21 12:19 ` Fabio Estevam
2012-09-21 12:53 ` Marek Vasut
2012-09-22 14:59 ` Artem Bityutskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201209052123.54695.marex@denx.de \
--to=marex@denx.de \
--cc=artem.bityutskiy@linux.intel.com \
--cc=b32955@freescale.com \
--cc=fabio.estevam@freescale.com \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox