From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from 12.mo4.mail-out.ovh.net ([178.33.104.253] helo=mo4.mail-out.ovh.net) by merlin.infradead.org with esmtp (Exim 4.76 #1 (Red Hat Linux)) id 1TK8nO-0001I7-DC for linux-mtd@lists.infradead.org; Fri, 05 Oct 2012 14:22:34 +0000 Received: from mail413.ha.ovh.net (b9.ovh.net [213.186.33.59]) by mo4.mail-out.ovh.net (Postfix) with SMTP id 4C3FE10502F4 for ; Fri, 5 Oct 2012 16:28:46 +0200 (CEST) Date: Fri, 5 Oct 2012 16:20:04 +0200 From: Jean-Christophe PLAGNIOL-VILLARD To: Linus Walleij Subject: Re: [PATCH 1/1] mtd: st fsmc_nand: pass the ale and cmd resource via resource Message-ID: <20121005142004.GB12462@game.jcrosoft.org> References: <1349356456-13371-1-git-send-email-plagnioj@jcrosoft.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Cc: Vipin Kumar , devicetree-discuss@lists.ozlabs.org, linux-mtd@lists.infradead.org, linux-arm-kernel@lists.infradead.org List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On 14:49 Fri 05 Oct , Linus Walleij wrote: > > On Thu, Oct 4, 2012 at 3:14 PM, Jean-Christophe PLAGNIOL-VILLARD > wrote: > > > Do not use the platform_data to pass resource and be smart in the drivers. > > Just pass it via resource > > > > Switch to devm_request_and_ioremap at the sametime > > > > Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD > > Cc: Linus Walleij > > Cc: Vipin Kumar > > Cc: linux-mtd@lists.infradead.org > > This is much better. Actually I was confused by these offsets recently... > Acked-by: Linus Walleij > > My patch to convert the Nomadik to the FSMC driver will collide with this, > but I can sure fix it up as we run into it, no big deal. ha you did it too I'll give it a try Best Regards, J.