From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Mike Frysinger <vapier.adi@gmail.com>
Cc: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>,
linux-mtd@lists.infradead.org, kernel@pengutronix.de,
Greg Ungerer <gerg@uclinux.org>
Subject: Re: [PATCH] [RFC] mtd/uclinux: support ROM and allow passing the base address
Date: Fri, 12 Oct 2012 09:41:00 +0200 [thread overview]
Message-ID: <20121012074100.GC639@pengutronix.de> (raw)
In-Reply-To: <CAMjpGUcRni7ni-FtVAN-pqnuHDK-WeeO6U=480K=1sCDhb7qjQ@mail.gmail.com>
On Thu, Oct 11, 2012 at 12:21:59AM -0400, Mike Frysinger wrote:
> On Mon, Oct 8, 2012 at 11:25 AM, Uwe Kleine-König wrote:
> > --- a/drivers/mtd/maps/uclinux.c
> > +++ b/drivers/mtd/maps/uclinux.c
> > @@ -23,12 +23,13 @@
> >
> > /****************************************************************************/
> >
> > -struct map_info uclinux_ram_map = {
> > - .name = "RAM",
> > - .phys = (unsigned long)__bss_stop,
> > +static struct map_info uclinux_ram_map = {
> > .size = 0,
> > };
>
> this change will break Blackfin systems. i mentioned last time
> someone tried to make this and we talked about adding a comment to
> prevent future breakage, but that seems to not have happened.
Will send a patch in a moment.
> i don't think's necessary either for the larger change here. use the logic:
> if (physaddr != -1)
> mapp->phys = physaddr;
> and keep the default initialization.
I keep my way as it seems to be more robust for possible future changes.
(I don't know if that will ever happen, but consider platform device
support or just a retry of instatiation after physaddr changed from
something back to -1.)
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |
next prev parent reply other threads:[~2012-10-12 7:41 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-08 15:25 [PATCH] [RFC] mtd/uclinux: support ROM and allow passing the base address Uwe Kleine-König
2012-10-09 3:29 ` Greg Ungerer
2012-10-09 8:44 ` Uwe Kleine-König
2012-10-09 10:37 ` Greg Ungerer
2012-10-10 7:58 ` Uwe Kleine-König
2012-10-12 4:46 ` Mike Frysinger
2012-10-12 5:57 ` Greg Ungerer
2012-10-12 7:22 ` Uwe Kleine-König
2012-10-12 16:09 ` Mike Frysinger
2012-10-12 16:22 ` Mike Frysinger
2012-10-15 14:00 ` Artem Bityutskiy
2012-10-11 4:21 ` Mike Frysinger
2012-10-11 6:13 ` Uwe Kleine-König
2012-10-12 7:41 ` Uwe Kleine-König [this message]
2012-10-12 16:18 ` Mike Frysinger
2012-10-12 7:41 ` [PATCH 1/2 RFC v2] " Uwe Kleine-König
2012-10-12 7:41 ` [PATCH 2/2] mtd/uclinux: add a comment about why uclinux_ram_map must not be static Uwe Kleine-König
2012-10-12 16:23 ` Mike Frysinger
2012-10-15 4:15 ` Greg Ungerer
2012-10-15 4:14 ` [PATCH 1/2 RFC v2] mtd/uclinux: support ROM and allow passing the base address Greg Ungerer
2012-10-15 6:58 ` Uwe Kleine-König
2012-10-16 1:13 ` Greg Ungerer
2012-10-16 6:56 ` Uwe Kleine-König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121012074100.GC639@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=artem.bityutskiy@linux.intel.com \
--cc=gerg@uclinux.org \
--cc=kernel@pengutronix.de \
--cc=linux-mtd@lists.infradead.org \
--cc=vapier.adi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox