From: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
To: David Woodhouse <dwmw2@infradead.org>
Cc: linux-mtd@lists.infradead.org, dedekind1@gmail.com
Subject: Re: [PATCH] [MTD] Adjust the NOR CFI flash timeouts to round better
Date: Mon, 15 Oct 2012 10:57:19 -0600 [thread overview]
Message-ID: <20121015165719.GB32563@obsidianresearch.com> (raw)
In-Reply-To: <1350317380.14124.26.camel@shinybook.infradead.org>
On Mon, Oct 15, 2012 at 09:09:40AM -0700, David Woodhouse wrote:
> So it's not *entirely* bogus, but it should certainly be cleaned up to
> use the msecs_to_jiffies() helpers... or preferably not use jiffies at
> all, perhaps.
No doubt this is part of why I've seen failures on my boards, the
timeout is too short by half and rounded wrong :)
A quick grep shows many cases in drivers/mtd that use division of HZ,
what would you like to see done here?
Jason
?? That's '??s', not 'us', for next time the patch is submitted. Welcome
to the 21st century.
Hmm.. I may need a new terminal and/or mail reader ;)
next prev parent reply other threads:[~2012-10-15 16:57 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-05 18:32 [PATCH] [MTD] Adjust the NOR CFI flash timeouts to round better Jason Gunthorpe
2012-10-15 13:42 ` Artem Bityutskiy
2012-10-15 16:09 ` David Woodhouse
2012-10-15 16:57 ` Jason Gunthorpe [this message]
2012-10-15 17:31 ` David Woodhouse
2012-10-15 17:49 ` Jason Gunthorpe
2012-10-15 18:32 ` David Woodhouse
2012-10-15 19:08 ` Jason Gunthorpe
2012-10-15 19:28 ` Artem Bityutskiy
2012-10-15 20:00 ` David Woodhouse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121015165719.GB32563@obsidianresearch.com \
--to=jgunthorpe@obsidianresearch.com \
--cc=dedekind1@gmail.com \
--cc=dwmw2@infradead.org \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox