From: Richard Weinberger <richard@nod.at>
To: dedekind1@gmail.com
Cc: linux-mtd@lists.infradead.org, Zach Sadecki <zsadecki@itwatchdogs.com>
Subject: Re: UBI wl_tree_add problems after PEB scrubbed
Date: Mon, 3 Dec 2012 16:02:58 +0100 [thread overview]
Message-ID: <20121203160258.4a719a67@spider.haslach.nod.at> (raw)
In-Reply-To: <1354545960.11583.17.camel@sauron.fi.intel.com>
Am Mon, 03 Dec 2012 16:46:00 +0200
schrieb Artem Bityutskiy <dedekind1@gmail.com>:
> /me looks at Richard...
/me looks at the code. ;)
> OK, I confirm that this is fastmap to blame. Namely, this commit:
CONFIG_MTD_UBI_FASTMAP is y and ubi.fm_autoconvert is 1, correct?
What tests are you using? ubi-tests?
Does the issue still happen if you disable ubi_self_check_all_ff() in
__wl_get_peb()
And yeah, that's a very stupid bug, I'm very sorry.
I'm running ubi-tests now for a while, self_check_ec() triggered once,
but I've never seen "UBI assert failed in wl_tree_add at 204" so far.
Thanks,
//richard
next prev parent reply other threads:[~2012-12-03 15:03 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-30 15:05 UBI wl_tree_add problems after PEB scrubbed Zach Sadecki
2012-12-03 10:48 ` Artem Bityutskiy
2012-12-03 11:01 ` Artem Bityutskiy
2012-12-03 11:19 ` Richard Weinberger
2012-12-03 14:46 ` Artem Bityutskiy
2012-12-03 15:02 ` Richard Weinberger [this message]
2012-12-03 15:33 ` Artem Bityutskiy
[not found] ` <1354564667-9549-1-git-send-email-richard@nod.at>
2012-12-03 19:57 ` [PATCH 1/2] ubi: Remove PEB from free tree in get_peb_for_wl() Richard Weinberger
2012-12-04 8:34 ` Artem Bityutskiy
2012-12-04 10:24 ` Richard Weinberger
2012-12-03 19:57 ` [PATCH 2/2] ubi: Dont call ubi_self_check_all_ff() in __wl_get_peb() Richard Weinberger
2012-12-04 7:55 ` Artem Bityutskiy
2012-12-04 7:56 ` Artem Bityutskiy
2012-12-04 8:15 ` Artem Bityutskiy
2012-12-04 9:15 ` Richard Weinberger
2012-12-04 14:45 ` UBI Fastmap fixes for 3.7 Zach Sadecki
2012-12-04 14:48 ` Richard Weinberger
2012-12-04 14:56 ` Zach Sadecki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121203160258.4a719a67@spider.haslach.nod.at \
--to=richard@nod.at \
--cc=dedekind1@gmail.com \
--cc=linux-mtd@lists.infradead.org \
--cc=zsadecki@itwatchdogs.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox