public inbox for linux-mtd@lists.infradead.org
 help / color / mirror / Atom feed
* [PATCH] mtd: mxc_nand: Make use of supplied pinctrl data
@ 2013-01-07 14:28 Marek Vasut
  2013-01-07 17:13 ` Sascha Hauer
  2013-01-08 19:58 ` Jean-Christophe PLAGNIOL-VILLARD
  0 siblings, 2 replies; 6+ messages in thread
From: Marek Vasut @ 2013-01-07 14:28 UTC (permalink / raw)
  To: linux-arm-kernel
  Cc: Marek Vasut, Artem Bityutskiy, Sascha Hauer, linux-mtd,
	Lothar Waßmann

The MXC NAND driver doesn't consider the pinctrl data supplied via DT, which
will result in NAND pins not being properly configured.

Make the driver use pinctrl, but to prevent breakage on various boards, do not
fail if the pinctrl data are not available, only print a warning message.

Signed-off-by: Marek Vasut <marex@denx.de>
Cc: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
Cc: Lothar Waßmann <LW@KARO-electronics.de>
Cc: Sascha Hauer <s.hauer@pengutronix.de>
---
 drivers/mtd/nand/mxc_nand.c |    6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/drivers/mtd/nand/mxc_nand.c b/drivers/mtd/nand/mxc_nand.c
index 45204e4..ed805fb 100644
--- a/drivers/mtd/nand/mxc_nand.c
+++ b/drivers/mtd/nand/mxc_nand.c
@@ -34,6 +34,7 @@
 #include <linux/completion.h>
 #include <linux/of_device.h>
 #include <linux/of_mtd.h>
+#include <linux/pinctrl/consumer.h>
 
 #include <asm/mach/flash.h>
 #include <linux/platform_data/mtd-mxc_nand.h>
@@ -1385,6 +1386,7 @@ static int mxcnd_probe(struct platform_device *pdev)
 	struct mtd_info *mtd;
 	struct mxc_nand_host *host;
 	struct resource *res;
+	struct pinctrl *pinctrl;
 	int err = 0;
 
 	/* Allocate memory for MTD device structure and private data */
@@ -1449,6 +1451,10 @@ static int mxcnd_probe(struct platform_device *pdev)
 	if (!res)
 		return -ENODEV;
 
+	pinctrl = devm_pinctrl_get_select_default(&pdev->dev);
+	if (IS_ERR(pinctrl))
+		dev_warn(&pdev->dev, "No PINCTRL data for the NAND driver!\n");
+
 	host->base = devm_request_and_ioremap(&pdev->dev, res);
 	if (!host->base)
 		return -ENOMEM;
-- 
1.7.10.4

^ permalink raw reply related	[flat|nested] 6+ messages in thread
* Re: [PATCH] mtd: mxc_nand: Make use of supplied pinctrl data
  2013-01-07 14:28 [PATCH] mtd: mxc_nand: Make use of supplied pinctrl data Marek Vasut
@ 2013-01-07 17:13 ` Sascha Hauer
  2013-01-08 19:58 ` Jean-Christophe PLAGNIOL-VILLARD
  1 sibling, 0 replies; 6+ messages in thread
From: Sascha Hauer @ 2013-01-07 17:13 UTC (permalink / raw)
  To: Marek Vasut
  Cc: Artem Bityutskiy, linux-mtd, linux-arm-kernel,
	Lothar Waßmann

On Mon, Jan 07, 2013 at 03:28:05PM +0100, Marek Vasut wrote:
> The MXC NAND driver doesn't consider the pinctrl data supplied via DT, which
> will result in NAND pins not being properly configured.
> 
> Make the driver use pinctrl, but to prevent breakage on various boards, do not
> fail if the pinctrl data are not available, only print a warning message.
> 
> Signed-off-by: Marek Vasut <marex@denx.de>
> Cc: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
> Cc: Lothar Waßmann <LW@KARO-electronics.de>
> Cc: Sascha Hauer <s.hauer@pengutronix.de>

Acked-by: Sascha Hauer <s.hauer@pengutronix.de>

Sascha

> ---
>  drivers/mtd/nand/mxc_nand.c |    6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/drivers/mtd/nand/mxc_nand.c b/drivers/mtd/nand/mxc_nand.c
> index 45204e4..ed805fb 100644
> --- a/drivers/mtd/nand/mxc_nand.c
> +++ b/drivers/mtd/nand/mxc_nand.c
> @@ -34,6 +34,7 @@
>  #include <linux/completion.h>
>  #include <linux/of_device.h>
>  #include <linux/of_mtd.h>
> +#include <linux/pinctrl/consumer.h>
>  
>  #include <asm/mach/flash.h>
>  #include <linux/platform_data/mtd-mxc_nand.h>
> @@ -1385,6 +1386,7 @@ static int mxcnd_probe(struct platform_device *pdev)
>  	struct mtd_info *mtd;
>  	struct mxc_nand_host *host;
>  	struct resource *res;
> +	struct pinctrl *pinctrl;
>  	int err = 0;
>  
>  	/* Allocate memory for MTD device structure and private data */
> @@ -1449,6 +1451,10 @@ static int mxcnd_probe(struct platform_device *pdev)
>  	if (!res)
>  		return -ENODEV;
>  
> +	pinctrl = devm_pinctrl_get_select_default(&pdev->dev);
> +	if (IS_ERR(pinctrl))
> +		dev_warn(&pdev->dev, "No PINCTRL data for the NAND driver!\n");
> +
>  	host->base = devm_request_and_ioremap(&pdev->dev, res);
>  	if (!host->base)
>  		return -ENOMEM;
> -- 
> 1.7.10.4
> 
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] mtd: mxc_nand: Make use of supplied pinctrl data
  2013-01-07 14:28 [PATCH] mtd: mxc_nand: Make use of supplied pinctrl data Marek Vasut
  2013-01-07 17:13 ` Sascha Hauer
@ 2013-01-08 19:58 ` Jean-Christophe PLAGNIOL-VILLARD
  2013-01-08 20:22   ` Marek Vasut
  1 sibling, 1 reply; 6+ messages in thread
From: Jean-Christophe PLAGNIOL-VILLARD @ 2013-01-08 19:58 UTC (permalink / raw)
  To: Marek Vasut
  Cc: Artem Bityutskiy, Sascha Hauer, linux-mtd, linux-arm-kernel,
	Lothar Waßmann

On 15:28 Mon 07 Jan     , Marek Vasut wrote:
> The MXC NAND driver doesn't consider the pinctrl data supplied via DT, which
> will result in NAND pins not being properly configured.
> 
> Make the driver use pinctrl, but to prevent breakage on various boards, do not
> fail if the pinctrl data are not available, only print a warning message.
nack

we will at bus level

Best Regards,
J.
> 
> Signed-off-by: Marek Vasut <marex@denx.de>
> Cc: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
> Cc: Lothar Waßmann <LW@KARO-electronics.de>
> Cc: Sascha Hauer <s.hauer@pengutronix.de>
> ---
>  drivers/mtd/nand/mxc_nand.c |    6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/drivers/mtd/nand/mxc_nand.c b/drivers/mtd/nand/mxc_nand.c
> index 45204e4..ed805fb 100644
> --- a/drivers/mtd/nand/mxc_nand.c
> +++ b/drivers/mtd/nand/mxc_nand.c
> @@ -34,6 +34,7 @@
>  #include <linux/completion.h>
>  #include <linux/of_device.h>
>  #include <linux/of_mtd.h>
> +#include <linux/pinctrl/consumer.h>
>  
>  #include <asm/mach/flash.h>
>  #include <linux/platform_data/mtd-mxc_nand.h>
> @@ -1385,6 +1386,7 @@ static int mxcnd_probe(struct platform_device *pdev)
>  	struct mtd_info *mtd;
>  	struct mxc_nand_host *host;
>  	struct resource *res;
> +	struct pinctrl *pinctrl;
>  	int err = 0;
>  
>  	/* Allocate memory for MTD device structure and private data */
> @@ -1449,6 +1451,10 @@ static int mxcnd_probe(struct platform_device *pdev)
>  	if (!res)
>  		return -ENODEV;
>  
> +	pinctrl = devm_pinctrl_get_select_default(&pdev->dev);
> +	if (IS_ERR(pinctrl))
> +		dev_warn(&pdev->dev, "No PINCTRL data for the NAND driver!\n");
> +
>  	host->base = devm_request_and_ioremap(&pdev->dev, res);
>  	if (!host->base)
>  		return -ENOMEM;
> -- 
> 1.7.10.4
> 
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] mtd: mxc_nand: Make use of supplied pinctrl data
  2013-01-08 19:58 ` Jean-Christophe PLAGNIOL-VILLARD
@ 2013-01-08 20:22   ` Marek Vasut
  2013-01-09  6:41     ` Shawn Guo
  0 siblings, 1 reply; 6+ messages in thread
From: Marek Vasut @ 2013-01-08 20:22 UTC (permalink / raw)
  To: Jean-Christophe PLAGNIOL-VILLARD
  Cc: Artem Bityutskiy, Sascha Hauer, linux-mtd, linux-arm-kernel,
	Lothar Waßmann

Dear Jean-Christophe PLAGNIOL-VILLARD,

> On 15:28 Mon 07 Jan     , Marek Vasut wrote:
> > The MXC NAND driver doesn't consider the pinctrl data supplied via DT,
> > which will result in NAND pins not being properly configured.
> > 
> > Make the driver use pinctrl, but to prevent breakage on various boards,
> > do not fail if the pinctrl data are not available, only print a warning
> > message.
> 
> nack
> 
> we will at bus level

Can you please elaborate? I don't understand what you're complaining about at 
all, sorry.

Best regards,
Marek Vasut

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] mtd: mxc_nand: Make use of supplied pinctrl data
  2013-01-08 20:22   ` Marek Vasut
@ 2013-01-09  6:41     ` Shawn Guo
  2013-01-09  9:08       ` Marek Vasut
  0 siblings, 1 reply; 6+ messages in thread
From: Shawn Guo @ 2013-01-09  6:41 UTC (permalink / raw)
  To: Marek Vasut
  Cc: Artem Bityutskiy, Sascha Hauer, linux-mtd,
	Jean-Christophe PLAGNIOL-VILLARD, linux-arm-kernel,
	Lothar Waßmann

On Tue, Jan 08, 2013 at 09:22:46PM +0100, Marek Vasut wrote:
> Dear Jean-Christophe PLAGNIOL-VILLARD,
> 
> > On 15:28 Mon 07 Jan     , Marek Vasut wrote:
> > > The MXC NAND driver doesn't consider the pinctrl data supplied via DT,
> > > which will result in NAND pins not being properly configured.
> > > 
> > > Make the driver use pinctrl, but to prevent breakage on various boards,
> > > do not fail if the pinctrl data are not available, only print a warning
> > > message.
> > 
> > nack
> > 
> > we will at bus level
> 
> Can you please elaborate? I don't understand what you're complaining about at 
> all, sorry.
> 
He is talking about patch [1] which is likely to hit mainline for 3.9.

Shawn

[1] http://thread.gmane.org/gmane.linux.kernel/1409263

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] mtd: mxc_nand: Make use of supplied pinctrl data
  2013-01-09  6:41     ` Shawn Guo
@ 2013-01-09  9:08       ` Marek Vasut
  0 siblings, 0 replies; 6+ messages in thread
From: Marek Vasut @ 2013-01-09  9:08 UTC (permalink / raw)
  To: Shawn Guo
  Cc: Artem Bityutskiy, Sascha Hauer, linux-mtd,
	Jean-Christophe PLAGNIOL-VILLARD, linux-arm-kernel,
	Lothar Waßmann

Dear Shawn Guo,

> On Tue, Jan 08, 2013 at 09:22:46PM +0100, Marek Vasut wrote:
> > Dear Jean-Christophe PLAGNIOL-VILLARD,
> > 
> > > On 15:28 Mon 07 Jan     , Marek Vasut wrote:
> > > > The MXC NAND driver doesn't consider the pinctrl data supplied via
> > > > DT, which will result in NAND pins not being properly configured.
> > > > 
> > > > Make the driver use pinctrl, but to prevent breakage on various
> > > > boards, do not fail if the pinctrl data are not available, only
> > > > print a warning message.
> > > 
> > > nack
> > > 
> > > we will at bus level
> > 
> > Can you please elaborate? I don't understand what you're complaining
> > about at all, sorry.
> 
> He is talking about patch [1] which is likely to hit mainline for 3.9.
> 
> Shawn
> 
> [1] http://thread.gmane.org/gmane.linux.kernel/1409263

Oh, this is good, thanks for explaining Shawn!

Well, this patch can be applied as a fallback if it doesn't hit 3.9 , either way 
works for me.

Best regards,
Marek Vasut

^ permalink raw reply	[flat|nested] 6+ messages in thread
end of thread, other threads:[~2013-01-09  9:08 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-01-07 14:28 [PATCH] mtd: mxc_nand: Make use of supplied pinctrl data Marek Vasut
2013-01-07 17:13 ` Sascha Hauer
2013-01-08 19:58 ` Jean-Christophe PLAGNIOL-VILLARD
2013-01-08 20:22   ` Marek Vasut
2013-01-09  6:41     ` Shawn Guo
2013-01-09  9:08       ` Marek Vasut

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox