Re: [PATCH RFC] mtd/nand: implement user otp for Micron chips

["Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>]

Hello,

On Thu, Feb 21, 2013 at 11:07:28AM +0100, Uwe Kleine-König wrote:
> > Shouldn't vendor specific code go in another file ?
> OK for me, I didn't notice any other vendor specific code and e.g. onfi
> stuff is in nand_base, too. (Maybe that is because it's not possible to
> see from the filenames under drivers/mtd/nand if that file defines a
> controller driver or some chip specific stuff.)
> 
> I will move it to a file nandchip-micron.c for the next submission. Does
> this look right?  I will wait for more feedback though.
I started to implement that now and one problem is that a few functions
(namely nand_get_device, nand_release_device and nand_onfi_set_features)
are statically defined in nand_base.c. The obvious options are:

 1) drop "static" from nand_get_device et al. and declare them in a
    header (say drivers/mtd/nand/nand.h);
 2) keep the implementation of the Micron stuff in nand_base.c; or
 3) put it into a nandchip-micron.c and #include that from nand_base.c

Did I miss something? David, Artem: Any thoughts/preferences?

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |