From: Dan Carpenter <dan.carpenter@oracle.com>
To: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
Cc: linux-mtd@lists.infradead.org
Subject: Re: UBIFS: make space fixup work in the remount case
Date: Mon, 15 Apr 2013 13:19:36 +0300 [thread overview]
Message-ID: <20130415101936.GM6692@mwanda> (raw)
In-Reply-To: <1366020693.2768.41.camel@sauron.fi.intel.com>
On Mon, Apr 15, 2013 at 01:11:33PM +0300, Artem Bityutskiy wrote:
> On Mon, 2013-04-15 at 12:59 +0300, Dan Carpenter wrote:
> > 1571 if (c->space_fixup) {
> > 1572 err = ubifs_fixup_free_space(c);
> > 1573 if (err)
> > 1574 return err;
> > ^^^^^^^^^^
> > Shouldn't this be a "goto out?". We're holding the c->umount_mutex.
>
> Hi Dan, I fixed this up and answered the reporter:
> https://patchwork.kernel.org/patch/2284681/
>
> It is now 'goto out'. Thanks!
Huh... That wasn't who I expected to report it. :P It's good to
know that these kind of bugs don't last very long.
regards,
dan carpenter
next prev parent reply other threads:[~2013-04-15 10:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20130415095924.GA26544@elgon.mountain>
2013-04-15 10:11 ` UBIFS: make space fixup work in the remount case Artem Bityutskiy
2013-04-15 10:19 ` Dan Carpenter [this message]
2013-04-15 10:39 ` Artem Bityutskiy
2014-04-01 13:39 ` Dan Carpenter
2014-04-07 10:43 ` Artem Bityutskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130415101936.GM6692@mwanda \
--to=dan.carpenter@oracle.com \
--cc=artem.bityutskiy@linux.intel.com \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).