From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from moutng.kundenserver.de ([212.227.17.10]) by merlin.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1UdK3M-0004rl-8X for linux-mtd@lists.infradead.org; Fri, 17 May 2013 12:46:32 +0000 From: Arnd Bergmann To: "Gupta, Pekon" Subject: Re: [PATCH 4/4 v2] ARM: OMAP2+: updated ECC scheme attributes for omap2-nand DT Date: Fri, 17 May 2013 14:46:05 +0200 References: <1368791418-14330-1-git-send-email-pekon@ti.com> <1368791418-14330-5-git-send-email-pekon@ti.com> In-Reply-To: <1368791418-14330-5-git-send-email-pekon@ti.com> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Message-Id: <201305171446.06023.arnd@arndb.de> Cc: tony@atomide.com, jp.francois@cynove.com, balbi@ti.com, linux-mtd@lists.infradead.org, linux-omap@vger.kernel.org List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Friday 17 May 2013, Gupta, Pekon wrote: > From: "Gupta, Pekon" > > Updates ECC scheme selection string same to same as used in omap2-driver code. > This makes the DT configurations easy to understand and map to actual code. > > Signed-off-by: Gupta, Pekon This moves the binding in the wrong direction. First of all, you should never make incompatible changes to a specification document. > - "bch8_hw_detection_sw" 8-bit BCH with ECC calculation in hardware > - and error detection in software > - - requires Kconfig CONFIG_MTD_NAND_ECC_BCH The binding before your change is already broken since it refers to Linux-specific Kconfig symbols, and you fail to fix that. > + "OMAP_ECC_BCH4_CODE_HW_DETECTION_SW" > + 4-bit BCH with ECC calculation in > + hardware & error detection in software. > + - requires CONFIG_MTD_NAND_ECC_BCH Instead you make it worse by using /more/ Linux-isms in the binding. Arnd