From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mail-lb0-f174.google.com ([209.85.217.174])
 by merlin.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux))
 id 1UloF8-0005F1-S7
 for linux-mtd@lists.infradead.org; Sun, 09 Jun 2013 22:37:47 +0000
Received: by mail-lb0-f174.google.com with SMTP id x10so3636785lbi.5
 for <linux-mtd@lists.infradead.org>; Sun, 09 Jun 2013 15:37:24 -0700 (PDT)
Date: Mon, 10 Jun 2013 00:39:20 +0200
From: Emil Goode <emilgoode@gmail.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Subject: Re: [PATCH] mtd: orion_nand: convert printk to dev_*
Message-ID: <20130609223920.GA3963@debian>
References: <1370812614-5724-1-git-send-email-andy.shevchenko@gmail.com>
 <20130609221808.GY23987@mwanda>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20130609221808.GY23987@mwanda>
Cc: artem.bityutskiy@linux.intel.com,
 Andy Shevchenko <andy.shevchenko@gmail.com>, linux-mtd@lists.infradead.org
List-Id: Linux MTD discussion mailing list <linux-mtd.lists.infradead.org>
List-Unsubscribe: <http://lists.infradead.org/mailman/options/linux-mtd>,
 <mailto:linux-mtd-request@lists.infradead.org?subject=unsubscribe>
List-Archive: <http://lists.infradead.org/pipermail/linux-mtd/>
List-Post: <mailto:linux-mtd@lists.infradead.org>
List-Help: <mailto:linux-mtd-request@lists.infradead.org?subject=help>
List-Subscribe: <http://lists.infradead.org/mailman/listinfo/linux-mtd>,
 <mailto:linux-mtd-request@lists.infradead.org?subject=subscribe>

Hello Dan,

Thank you for pointing this out, I was going to send a second version
and fix that typo anyway so I will send a patch that applies on top
of Andy's patch and also remove that error message for kzalloc.

Best regards,

Emil

On Mon, Jun 10, 2013 at 01:18:08AM +0300, Dan Carpenter wrote:
> On Mon, Jun 10, 2013 at 12:16:54AM +0300, Andy Shevchenko wrote:
> > It's better to use actual device name as a prefix in error messages.
> > 
> 
> Gar...
> 
> This doesn't apply on top of Emil's patch.  Emil's patch was first
> so it should go in first.  Also Emil's patch was a bugfix so it is
> more important than this printk cleanup patch.
> 
> Really, the kzalloc error messages should just be deleted.  They are
> cargo cult error messages as in "we need an error message because
> we are copy and pasting from other code without thinking."  Kzalloc
> already has far better messages built in.
> 
> Ah well...
> 
> regards,
> dan carpenter