From: Emil Goode <emilgoode@gmail.com>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: artem.bityutskiy@linux.intel.com, linux-mtd@lists.infradead.org,
Dan Carpenter <dan.carpenter@oracle.com>
Subject: Re: [PATCH] mtd: orion_nand: convert printk to dev_*
Date: Mon, 10 Jun 2013 01:34:01 +0200 [thread overview]
Message-ID: <20130609233401.GA4413@debian> (raw)
In-Reply-To: <CAHp75VfYUL-odEZH4S3eskzD5Xs2Xc8Sbvy_7xE=yJaM1PiUBg@mail.gmail.com>
Hello Andy,
Thanks for the hint about converting to dev*. But I agree with Dan that error
messages for kzalloc calls are a bit pointless and after removing them all the
dev* calls are gone. So I will send a second version that fixes the typo and
removes the error messages for kzalloc. If you have any objections let me know.
Best regards,
Emil
On Mon, Jun 10, 2013 at 01:31:27AM +0300, Andy Shevchenko wrote:
> On Mon, Jun 10, 2013 at 1:18 AM, Dan Carpenter <dan.carpenter@oracle.com> wrote:
> > On Mon, Jun 10, 2013 at 12:16:54AM +0300, Andy Shevchenko wrote:
> >> It's better to use actual device name as a prefix in error messages.
> >>
> >
> > Gar...
> >
> > This doesn't apply on top of Emil's patch. Emil's patch was first
> > so it should go in first. Also Emil's patch was a bugfix so it is
> > more important than this printk cleanup patch.
>
> Which tree has that patch incorporated? I'm okay to rebase it against that tree.
> Current version was done against recent linux-next.
>
> --
> With Best Regards,
> Andy Shevchenko
next prev parent reply other threads:[~2013-06-09 23:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-09 21:16 [PATCH] mtd: orion_nand: convert printk to dev_* Andy Shevchenko
2013-06-09 22:18 ` Dan Carpenter
2013-06-09 22:31 ` Andy Shevchenko
2013-06-09 23:34 ` Emil Goode [this message]
2013-06-09 22:39 ` Emil Goode
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130609233401.GA4413@debian \
--to=emilgoode@gmail.com \
--cc=andy.shevchenko@gmail.com \
--cc=artem.bityutskiy@linux.intel.com \
--cc=dan.carpenter@oracle.com \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).