From: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
To: Brian Norris <computersforpeace@gmail.com>
Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>,
Lior Amsalem <alior@marvell.com>,
Jason Cooper <jason@lakedaemon.net>,
Artem Bityutskiy <dedekind1@gmail.com>,
leiwen@marvell.com, haojian.zhuang@gmail.com, zonque@gmail.com,
linux-mtd@lists.infradead.org, grinberg@compulab.co.il,
Gregory Clement <gregory.clement@free-electrons.com>,
eric.miao@marvell.com, David Woodhouse <dwmw2@infradead.org>,
Willy Tarreau <w@1wt.eu>,
nikita@compulab.co.il
Subject: Re: [PATCH 10/13] mtd: nand: pxa3xx: Add inline keyword to enable_int()
Date: Tue, 30 Jul 2013 09:53:55 -0300 [thread overview]
Message-ID: <20130730125354.GA2375@localhost> (raw)
In-Reply-To: <CAN8TOE_F1Qu6XP54aVG_rmYn5wgBEZFYOzk+eYa_Fuxh9FYmFQ@mail.gmail.com>
On Tue, Jul 30, 2013 at 12:47:33AM -0700, Brian Norris wrote:
> On Mon, Jul 29, 2013 at 4:24 PM, Ezequiel Garcia
> <ezequiel.garcia@free-electrons.com> wrote:
> > Now that we have added ARCH_HAS_DMA conditional the function
> > enable_int() may be unused. So we declare it as inline
> > in order to remove the following warning, when the function is not used:
>
> I haven't reviewed the rest too well yet, but I think you want the
> '__maybe_unused' qualifier, not 'inline'.
>
> > drivers/mtd/nand//pxa3xx_nand.c:343:24: warning: 'enable_int' defined
> > but not used [-Wunused-function]
Mmm, I guess you're right. I did this patch a long time ago, and now I'm
wondering if there is any reason why I haven't used that in the first place.
Anyway... I'll fix and re-post.
Thanks for the feedback!
--
Ezequiel García, Free Electrons
Embedded Linux, Kernel and Android Engineering
http://free-electrons.com
next prev parent reply other threads:[~2013-07-30 12:54 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-29 23:24 [PATCH 00/13] pxa3xx patches to support mvebu builds Ezequiel Garcia
2013-07-29 23:24 ` [PATCH 01/13] mtd: nand: pxa3xx: Handle ECC and DMA enable/disable properly Ezequiel Garcia
2013-07-29 23:24 ` [PATCH 02/13] mtd: nand: pxa3xx: Allow to set/clear the 'spare enable' field Ezequiel Garcia
2013-07-29 23:24 ` [PATCH 03/13] mtd: nand: pxa3xx: Support command buffer #3 Ezequiel Garcia
2013-07-29 23:24 ` [PATCH 04/13] mtd: nand: pxa3xx: Use 'length override' in ONFI paramater page read Ezequiel Garcia
2013-07-29 23:24 ` [PATCH 05/13] mtd: nand: pxa3xx: Add a local loop variable Ezequiel Garcia
2013-07-29 23:24 ` [PATCH 06/13] mtd: nand: pxa3xx: Remove hardcoded mtd name Ezequiel Garcia
2013-07-29 23:24 ` [PATCH 07/13] mtd: nand: pxa3xx: Remove uneeded internal cmdset Ezequiel Garcia
2013-07-29 23:24 ` [PATCH 08/13] mtd: nand: pxa3xx: Move cached registers to info structure Ezequiel Garcia
2013-07-29 23:24 ` [PATCH 09/13] mtd: nand: pxa3xx: Make dma code dependent on dma capable platforms Ezequiel Garcia
2013-07-29 23:24 ` [PATCH 10/13] mtd: nand: pxa3xx: Add inline keyword to enable_int() Ezequiel Garcia
2013-07-30 7:47 ` Brian Norris
2013-07-30 12:53 ` Ezequiel Garcia [this message]
2013-07-29 23:24 ` [PATCH 11/13] mtd: nand: pxa3xx: Allow devices with no dma resources Ezequiel Garcia
2013-07-29 23:24 ` [PATCH 12/13] mtd: nand: pxa3xx-nand: Increase data buffer size Ezequiel Garcia
2013-07-29 23:24 ` [PATCH 13/13] mtd: nand: Allow to build pxa3xx_nand on Orion platforms Ezequiel Garcia
2013-07-30 7:43 ` [PATCH 00/13] pxa3xx patches to support mvebu builds Daniel Mack
2013-07-30 7:53 ` Thomas Petazzoni
2013-07-30 8:02 ` Daniel Mack
2013-07-30 8:18 ` Thomas Petazzoni
2013-07-30 13:15 ` Ezequiel Garcia
2013-07-30 13:22 ` Daniel Mack
2013-07-30 13:38 ` Ezequiel Garcia
2013-07-31 0:58 ` Chao Xie
2013-07-31 11:51 ` Daniel Mack
2013-07-31 15:17 ` Ezequiel Garcia
2013-08-01 10:16 ` Daniel Mack
2013-08-01 10:21 ` Ezequiel Garcia
2013-08-01 10:47 ` Daniel Mack
2013-08-01 10:59 ` Ezequiel Garcia
2013-08-01 11:07 ` Daniel Mack
2013-08-07 12:04 ` Daniel Mack
2013-08-07 12:18 ` Ezequiel Garcia
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130730125354.GA2375@localhost \
--to=ezequiel.garcia@free-electrons.com \
--cc=alior@marvell.com \
--cc=computersforpeace@gmail.com \
--cc=dedekind1@gmail.com \
--cc=dwmw2@infradead.org \
--cc=eric.miao@marvell.com \
--cc=gregory.clement@free-electrons.com \
--cc=grinberg@compulab.co.il \
--cc=haojian.zhuang@gmail.com \
--cc=jason@lakedaemon.net \
--cc=leiwen@marvell.com \
--cc=linux-mtd@lists.infradead.org \
--cc=nikita@compulab.co.il \
--cc=thomas.petazzoni@free-electrons.com \
--cc=w@1wt.eu \
--cc=zonque@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox