From: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
To: Daniel Mack <zonque@gmail.com>
Cc: Lior Amsalem <alior@marvell.com>,
Thomas Petazzoni <thomas.petazzoni@free-electrons.com>,
Jason Cooper <jason@lakedaemon.net>,
Artem Bityutskiy <dedekind1@gmail.com>,
leiwen@marvell.com, haojian.zhuang@gmail.com,
Chao Xie <chao.xie@marvell.com>,
linux-mtd@lists.infradead.org, grinberg@compulab.co.il,
Gregory Clement <gregory.clement@free-electrons.com>,
eric.miao@marvell.com, computersforpeace@gmail.com,
David Woodhouse <dwmw2@infradead.org>, Willy Tarreau <w@1wt.eu>,
nikita@compulab.co.il
Subject: Re: [PATCH 00/13] pxa3xx patches to support mvebu builds
Date: Tue, 30 Jul 2013 10:15:39 -0300 [thread overview]
Message-ID: <20130730131538.GB2375@localhost> (raw)
In-Reply-To: <20130730101809.7c28525c@skate>
Hello Daniel,
On Tue, Jul 30, 2013 at 10:18:09AM +0200, Thomas Petazzoni wrote:
> On Tue, 30 Jul 2013 10:02:04 +0200, Daniel Mack wrote:
> > On 30.07.2013 09:53, Thomas Petazzoni wrote:
> > > On Tue, 30 Jul 2013 09:43:54 +0200, Daniel Mack wrote:
> > >> Interesting, because I'm working on a dmaengine implementation for
> > >> PXA right now. I'm not even half through, but I'm making progress,
> > >> and I'm not sure yet how to merge it. Because there won't be any
> > >> migration path, it'll be a bigger set that has to go in in one in
> > >> order to prevent build breakage.
> > >
> > > Aren't drivers/dma/mmp_pdma.c and drivers/dma/mmp_tdma.c already
> > > dmaengine drivers for PXA ?
> >
> > Yes, I saw the pdma driver as well, after I started my own
> > implementation. However, the tree is full of users of the proprietary
> > API, and moving them over won't be gap-less.
>
Mmmm.. I'm a bit confused by this: is your dmaengine driver any
different/better from the already existent mmp_{p,t}dma.c ?
(I'm sure I've misunderstood something, otherwise why would you be
working in something that's already available?)
> Indeed. Some patches migrating the pxa3xx_nand driver to use the
> dmaengine API have been posted a while ago, but they haven't been
> merged because one needs to convert *all* the PXA drivers to the
> dmaengine API to get the thing working.
>
Here's a patch posted in July 2012 converting pxa3xx-nand to dmaengine.
That patch was never merged because (just as Thomas says) both
dma drivers (mmp dmaengine on one side, mach-pxa dma on the other) don't
work together. In other words, you have to convert *all* drivers at the
same time.
Thomas proposed an idea for this conversion a few months ago: (quoting
him from IRC)
"""
First have a patch that reimplements the existing plat-pxa/dma.c API on
top of dmaengine, so that you don't have to change any driver.
Then, go through each driver, one per patch to switch to the dmaengine API.
And finally get rid of the compatibility layer created in the first
patch.
"""
Does this sound sane?
--
Ezequiel García, Free Electrons
Embedded Linux, Kernel and Android Engineering
http://free-electrons.com
next prev parent reply other threads:[~2013-07-30 13:16 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-29 23:24 [PATCH 00/13] pxa3xx patches to support mvebu builds Ezequiel Garcia
2013-07-29 23:24 ` [PATCH 01/13] mtd: nand: pxa3xx: Handle ECC and DMA enable/disable properly Ezequiel Garcia
2013-07-29 23:24 ` [PATCH 02/13] mtd: nand: pxa3xx: Allow to set/clear the 'spare enable' field Ezequiel Garcia
2013-07-29 23:24 ` [PATCH 03/13] mtd: nand: pxa3xx: Support command buffer #3 Ezequiel Garcia
2013-07-29 23:24 ` [PATCH 04/13] mtd: nand: pxa3xx: Use 'length override' in ONFI paramater page read Ezequiel Garcia
2013-07-29 23:24 ` [PATCH 05/13] mtd: nand: pxa3xx: Add a local loop variable Ezequiel Garcia
2013-07-29 23:24 ` [PATCH 06/13] mtd: nand: pxa3xx: Remove hardcoded mtd name Ezequiel Garcia
2013-07-29 23:24 ` [PATCH 07/13] mtd: nand: pxa3xx: Remove uneeded internal cmdset Ezequiel Garcia
2013-07-29 23:24 ` [PATCH 08/13] mtd: nand: pxa3xx: Move cached registers to info structure Ezequiel Garcia
2013-07-29 23:24 ` [PATCH 09/13] mtd: nand: pxa3xx: Make dma code dependent on dma capable platforms Ezequiel Garcia
2013-07-29 23:24 ` [PATCH 10/13] mtd: nand: pxa3xx: Add inline keyword to enable_int() Ezequiel Garcia
2013-07-30 7:47 ` Brian Norris
2013-07-30 12:53 ` Ezequiel Garcia
2013-07-29 23:24 ` [PATCH 11/13] mtd: nand: pxa3xx: Allow devices with no dma resources Ezequiel Garcia
2013-07-29 23:24 ` [PATCH 12/13] mtd: nand: pxa3xx-nand: Increase data buffer size Ezequiel Garcia
2013-07-29 23:24 ` [PATCH 13/13] mtd: nand: Allow to build pxa3xx_nand on Orion platforms Ezequiel Garcia
2013-07-30 7:43 ` [PATCH 00/13] pxa3xx patches to support mvebu builds Daniel Mack
2013-07-30 7:53 ` Thomas Petazzoni
2013-07-30 8:02 ` Daniel Mack
2013-07-30 8:18 ` Thomas Petazzoni
2013-07-30 13:15 ` Ezequiel Garcia [this message]
2013-07-30 13:22 ` Daniel Mack
2013-07-30 13:38 ` Ezequiel Garcia
2013-07-31 0:58 ` Chao Xie
2013-07-31 11:51 ` Daniel Mack
2013-07-31 15:17 ` Ezequiel Garcia
2013-08-01 10:16 ` Daniel Mack
2013-08-01 10:21 ` Ezequiel Garcia
2013-08-01 10:47 ` Daniel Mack
2013-08-01 10:59 ` Ezequiel Garcia
2013-08-01 11:07 ` Daniel Mack
2013-08-07 12:04 ` Daniel Mack
2013-08-07 12:18 ` Ezequiel Garcia
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130730131538.GB2375@localhost \
--to=ezequiel.garcia@free-electrons.com \
--cc=alior@marvell.com \
--cc=chao.xie@marvell.com \
--cc=computersforpeace@gmail.com \
--cc=dedekind1@gmail.com \
--cc=dwmw2@infradead.org \
--cc=eric.miao@marvell.com \
--cc=gregory.clement@free-electrons.com \
--cc=grinberg@compulab.co.il \
--cc=haojian.zhuang@gmail.com \
--cc=jason@lakedaemon.net \
--cc=leiwen@marvell.com \
--cc=linux-mtd@lists.infradead.org \
--cc=nikita@compulab.co.il \
--cc=thomas.petazzoni@free-electrons.com \
--cc=w@1wt.eu \
--cc=zonque@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox