Re: [PATCH 00/13] pxa3xx patches to support mvebu builds

Ezequiel Garcia
2013-08-07T12:19:30Z

On Wed, Aug 07, 2013 at 02:04:51PM +0200, Daniel Mack wrote:
> Hi Ezequiel,
>
> On 01.08.2013 12:59, Ezequiel Garcia wrote:
> > On Thu, Aug 01, 2013 at 12:47:56PM +0200, Daniel Mack wrote:
>
> >> fbd70cb71103051699c7c49b08d5e107736e3a75 is the first bad commit
> >> commit fbd70cb71103051699c7c49b08d5e107736e3a75
> >> Author: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
> >> Date: Mon Jul 29 20:24:13 2013 -0300
> >>
> >> mtd: nand: pxa3xx: Support command buffer #3
> >>
> >> Some newer controllers support a fourth command buffer. This additional
> >> command buffer allows to set an arbitrary length count, using the
> >> NDCB3.NDLENCNT field, to perform non-standard length operations
> >> such as the ONFI parameter page read.
> >>
> >> In controllers without this register, the operation has no effect.
> >
> > ^^^
> > So the above does not hold :-(
> >
> > Given this shows a significant distinction between PXA NAND controller
> > (what we could call NFCv1) and Armada 370/XP NAND controller (NFCv2)
> > I see no way but to introduce a new compatible string for this driver.
> >
> > Following the convention of choosing the first SoC that introduces the
> > controller, the new compatible would be "marvell,armada370-nand".
> >
> > How does this sound?
> >
>
> Are you planning a new version of this series? I'd like to base my
> pxa-dma patches on top of yours ...
>
>

Yes, I was just about to send it.

--
Ezequiel García, Free Electrons
Embedded Linux, Kernel and Android Engineering