From: "Jörn Engel" <joern@logfs.org>
To: Jussi Kivilinna <jussi.kivilinna@iki.fi>
Cc: David Woodhouse <dwmw2@infradead.org>,
linux-usb@vger.kernel.org, linux-mtd@lists.infradead.org
Subject: Re: [PATCH] alauda: do not use stack for URB transfer_buffers
Date: Wed, 7 Aug 2013 11:16:12 -0400 [thread overview]
Message-ID: <20130807151612.GA18545@logfs.org> (raw)
In-Reply-To: <5201E03D.30306@iki.fi>
On Wed, 7 August 2013 08:50:53 +0300, Jussi Kivilinna wrote:
> On 06.08.2013 19:49, Jörn Engel wrote:
> > On Tue, 6 August 2013 15:03:29 +0300, Jussi Kivilinna wrote:
> >>
> >> Patch fixes alauda not to use stack as URB transfer_buffer. URB buffers need to
> >> be DMA-able, which stack is not.
> >>
> >> Patch is only compile tested.
> >
> > I have tested the driver back when I wrote it. Not sure why it worked
> > then, maybe the chip in my notebook back then didn't care about
> > alignment or I just got lucky with the memory allocations.
>
> You might not see problems with your hardware/architecture.
>
> "Documentation/DMA-API-HOWTO.txt" discusses about "What memory is DMA'able?".
Makes sense. I've read your patch over and it also makes sense.
Acked-by: Joern Engel <joern@logfs.org>
Jörn
--
It's just what we asked for, but not what we want!
-- anonymous
next prev parent reply other threads:[~2013-08-07 16:49 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-06 12:03 [PATCH] alauda: do not use stack for URB transfer_buffers Jussi Kivilinna
2013-08-06 16:49 ` Jörn Engel
2013-08-07 5:50 ` Jussi Kivilinna
2013-08-07 15:16 ` Jörn Engel [this message]
2013-08-21 7:30 ` Brian Norris
2013-08-21 7:59 ` Bjørn Mork
2013-08-21 8:41 ` Brian Norris
2013-08-21 9:59 ` Jussi Kivilinna
2013-08-21 20:00 ` Brian Norris
2013-08-21 19:06 ` Jörn Engel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130807151612.GA18545@logfs.org \
--to=joern@logfs.org \
--cc=dwmw2@infradead.org \
--cc=jussi.kivilinna@iki.fi \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox