From: Brian Norris <computersforpeace@gmail.com>
To: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>,
Lior Amsalem <alior@marvell.com>,
Jason Cooper <jason@lakedaemon.net>,
Artem Bityutskiy <dedekind1@gmail.com>,
Daniel Mack <zonque@gmail.com>,
linux-mtd@lists.infradead.org,
Gregory Clement <gregory.clement@free-electrons.com>,
David Woodhouse <dwmw2@infradead.org>, Willy Tarreau <w@1wt.eu>
Subject: Re: [PATCH v3 14/15] mtd: nand: pxa3xx: Increase data buffer size
Date: Sat, 10 Aug 2013 20:30:45 -0700 [thread overview]
Message-ID: <20130811033045.GA16906@norris.computersforpeace.net> (raw)
In-Reply-To: <1376163305-5591-15-git-send-email-ezequiel.garcia@free-electrons.com>
On Sat, Aug 10, 2013 at 04:35:04PM -0300, Ezequiel Garcia wrote:
> Devices with 4 KiB pages (plus OOB data) can be detected, so we increase
> the data buffer size. A better solution would be to allocate a buffer
> depending on the detected page size, but that's not possible given
> we need the buffer prior to the device detection.
Another possibility (for future work, maybe) is that you allocate a
smaller buffer that fits what you need for "device detection" (I presume
it's just for ONFI parameter page commands?), then reallocate the buffer
between nand_scan_ident() and nand_scan_tail() according to page size.
There are some other similar buffers throughout NAND that use a fixed
NAND_MAX_OOBSIZE and NAND_MAX_PAGESIZE.
> Signed-off-by: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
> Tested-by: Daniel Mack <zonque@gmail.com>
...
Brian
next prev parent reply other threads:[~2013-08-11 3:31 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-10 19:34 [PATCH v3 00/15] pxa3xx-nand patches to support mvebu builds Ezequiel Garcia
2013-08-10 19:34 ` [PATCH v3 01/15] mtd: nand: pxa3xx: Remove unneeded ifdef CONFIG_OF Ezequiel Garcia
2013-08-10 19:34 ` [PATCH v3 02/15] mtd: nand: pxa3xx: Introduce 'marvell, armada370-nand' compatible string Ezequiel Garcia
2013-08-10 19:34 ` [PATCH v3 03/15] mtd: nand: pxa3xx: Handle ECC and DMA enable/disable properly Ezequiel Garcia
2013-08-10 19:34 ` [PATCH v3 04/15] mtd: nand: pxa3xx: Allow to set/clear the 'spare enable' field Ezequiel Garcia
2013-08-10 19:34 ` [PATCH v3 05/15] mtd: nand: pxa3xx: Support command buffer #3 Ezequiel Garcia
2013-08-10 20:53 ` Brian Norris
2013-08-10 21:48 ` Thomas Petazzoni
2013-08-11 2:33 ` Brian Norris
2013-08-12 15:38 ` Ezequiel Garcia
2013-08-10 19:34 ` [PATCH v3 06/15] mtd: nand: pxa3xx: Use 'length override' in ONFI paramater page read Ezequiel Garcia
2013-08-10 19:34 ` [PATCH v3 07/15] mtd: nand: pxa3xx: Add a local loop variable Ezequiel Garcia
2013-08-10 19:34 ` [PATCH v3 08/15] mtd: nand: pxa3xx: Remove hardcoded mtd name Ezequiel Garcia
2013-08-10 19:34 ` [PATCH v3 09/15] mtd: nand: pxa3xx: Remove uneeded internal cmdset Ezequiel Garcia
2013-08-10 19:35 ` [PATCH v3 10/15] mtd: nand: pxa3xx: Move cached registers to info structure Ezequiel Garcia
2013-08-10 19:35 ` [PATCH v3 11/15] mtd: nand: pxa3xx: Make dma code dependent on dma capable platforms Ezequiel Garcia
2013-08-10 19:35 ` [PATCH v3 12/15] mtd: nand: pxa3xx: Add __maybe_unused keyword to enable_int() Ezequiel Garcia
2013-08-10 19:35 ` [PATCH v3 13/15] mtd: nand: pxa3xx: Allow devices with no dma resources Ezequiel Garcia
2013-08-10 19:35 ` [PATCH v3 14/15] mtd: nand: pxa3xx: Increase data buffer size Ezequiel Garcia
2013-08-11 3:30 ` Brian Norris [this message]
2013-08-12 15:48 ` Ezequiel Garcia
2013-08-10 19:35 ` [PATCH v3 15/15] mtd: nand: Allow to build pxa3xx_nand on Orion platforms Ezequiel Garcia
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130811033045.GA16906@norris.computersforpeace.net \
--to=computersforpeace@gmail.com \
--cc=alior@marvell.com \
--cc=dedekind1@gmail.com \
--cc=dwmw2@infradead.org \
--cc=ezequiel.garcia@free-electrons.com \
--cc=gregory.clement@free-electrons.com \
--cc=jason@lakedaemon.net \
--cc=linux-mtd@lists.infradead.org \
--cc=thomas.petazzoni@free-electrons.com \
--cc=w@1wt.eu \
--cc=zonque@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox