public inbox for linux-mtd@lists.infradead.org
 help / color / mirror / Atom feed
From: Brian Norris <computersforpeace@gmail.com>
To: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>,
	Lior Amsalem <alior@marvell.com>,
	Jason Cooper <jason@lakedaemon.net>,
	Artem Bityutskiy <dedekind1@gmail.com>,
	Daniel Mack <zonque@gmail.com>,
	linux-mtd@lists.infradead.org,
	Gregory Clement <gregory.clement@free-electrons.com>,
	David Woodhouse <dwmw2@infradead.org>, Willy Tarreau <w@1wt.eu>
Subject: Re: [PATCH v4 00/14] pxa3xx-nand patches to support mvebu builds
Date: Mon, 12 Aug 2013 16:19:46 -0700	[thread overview]
Message-ID: <20130812231946.GB7267@brian-ubuntu> (raw)
In-Reply-To: <1376327699-7973-1-git-send-email-ezequiel.garcia@free-electrons.com>

On Mon, Aug 12, 2013 at 02:14:45PM -0300, Ezequiel Garcia wrote:
> This patchset is part of the work I'm doing to enable the pxa3xx-nand
> driver to support the NAND controller in Armada 370/XP. While this is
> work in progress, here's a subset of patches I consider good enough
> for mainline.

[snip]

> If at all possible and if no regressions are reported I'd like to see
> this queued for v3.12.
> 
> Changes from v3:
>   This new version has some very minor differences from the previous one:
>   * Dropped patch "mtd: nand: pxa3xx: Increase data buffer size".
>     This will be re-worked following a suggestion from Brian.
> 
>   * Fix commit message for patch "mtd: nand: pxa3xx: Support command buffer #3"
>     and add some comments to clarify the command buffer loading behavior.
> 
> Changes from v2:
> 
>   * Remove ifdef CONFIG_OF from the driver as suggested by Brian Norris.
> 
>   * Rework patch 01/15: "mtd: nand: pxa3xx: Introduce 'marvell,armada370...",
>     according to the above change.
> 
> Changes from v1:
> 
>   * Use __maybe_unused instead of inline keyword for a symbol
>     that's maybe unused. Suggested by Brian Norris.
> 
>   * As Daniel Mack reported, the PXA nand controller (NFCv1)
>     lacks an NDBC3 register and it's access is undefined.
>     This means we need a way to distinguish between the two
>     controllers (NFCv1 and NFCv2).
> 
>     We introduce a new 'marvell,armada370-nand' compatible
>     string to distinguish the newer controller (NFCv2).
> 
> 
> Ezequiel Garcia (14):
>   mtd: nand: pxa3xx: Remove unneeded ifdef CONFIG_OF
>   mtd: nand: pxa3xx: Introduce 'marvell,armada370-nand' compatible
>     string

This series includes an older version of the above patch, without the
Tested-by and with a trivial change in the spacing. I just pulled in the
v3 patch.

>   mtd: nand: pxa3xx: Handle ECC and DMA enable/disable properly
>   mtd: nand: pxa3xx: Allow to set/clear the 'spare enable' field
>   mtd: nand: pxa3xx: Support command buffer #3
>   mtd: nand: pxa3xx: Use 'length override' in ONFI paramater page read
>   mtd: nand: pxa3xx: Add a local loop variable
>   mtd: nand: pxa3xx: Remove hardcoded mtd name
>   mtd: nand: pxa3xx: Remove uneeded internal cmdset
>   mtd: nand: pxa3xx: Move cached registers to info structure
>   mtd: nand: pxa3xx: Make dma code dependent on dma capable platforms
>   mtd: nand: pxa3xx: Add __maybe_unused keyword to enable_int()
>   mtd: nand: pxa3xx: Allow devices with no dma resources
>   mtd: nand: Allow to build pxa3xx_nand on Orion platforms
> 
>  drivers/mtd/nand/Kconfig                      |   2 +-
>  drivers/mtd/nand/pxa3xx_nand.c                | 277 ++++++++++++++++----------
>  include/linux/platform_data/mtd-nand-pxa3xx.h |  13 --
>  3 files changed, 173 insertions(+), 119 deletions(-)

Pushed the whole series to l2-mtd.git, although I noted one comment in
patch 8. Thanks!

Brian

  parent reply	other threads:[~2013-08-12 23:20 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-12 17:14 [PATCH v4 00/14] pxa3xx-nand patches to support mvebu builds Ezequiel Garcia
2013-08-12 17:14 ` [PATCH v4 01/14] mtd: nand: pxa3xx: Remove unneeded ifdef CONFIG_OF Ezequiel Garcia
2013-08-30 20:06   ` David Woodhouse
2013-08-31 16:53     ` Ezequiel Garcia
2013-09-16 22:57   ` Olof Johansson
2013-08-12 17:14 ` [PATCH v4 02/14] mtd: nand: pxa3xx: Introduce 'marvell, armada370-nand' compatible string Ezequiel Garcia
2013-08-12 17:14 ` [PATCH v4 03/14] mtd: nand: pxa3xx: Handle ECC and DMA enable/disable properly Ezequiel Garcia
2013-08-12 17:14 ` [PATCH v4 04/14] mtd: nand: pxa3xx: Allow to set/clear the 'spare enable' field Ezequiel Garcia
2013-08-12 17:14 ` [PATCH v4 05/14] mtd: nand: pxa3xx: Support command buffer #3 Ezequiel Garcia
2013-08-12 17:14 ` [PATCH v4 06/14] mtd: nand: pxa3xx: Use 'length override' in ONFI paramater page read Ezequiel Garcia
2013-08-12 17:14 ` [PATCH v4 07/14] mtd: nand: pxa3xx: Add a local loop variable Ezequiel Garcia
2013-08-12 17:14 ` [PATCH v4 08/14] mtd: nand: pxa3xx: Remove hardcoded mtd name Ezequiel Garcia
2013-08-12 23:18   ` Brian Norris
2013-08-12 17:14 ` [PATCH v4 09/14] mtd: nand: pxa3xx: Remove uneeded internal cmdset Ezequiel Garcia
2013-08-12 17:14 ` [PATCH v4 10/14] mtd: nand: pxa3xx: Move cached registers to info structure Ezequiel Garcia
2013-08-12 17:14 ` [PATCH v4 11/14] mtd: nand: pxa3xx: Make dma code dependent on dma capable platforms Ezequiel Garcia
2013-08-12 17:14 ` [PATCH v4 12/14] mtd: nand: pxa3xx: Add __maybe_unused keyword to enable_int() Ezequiel Garcia
2013-08-12 17:14 ` [PATCH v4 13/14] mtd: nand: pxa3xx: Allow devices with no dma resources Ezequiel Garcia
2013-08-12 17:14 ` [PATCH v4 14/14] mtd: nand: Allow to build pxa3xx_nand on Orion platforms Ezequiel Garcia
2013-08-12 23:19 ` Brian Norris [this message]
2013-08-13 11:37   ` [PATCH v4 00/14] pxa3xx-nand patches to support mvebu builds Ezequiel Garcia

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130812231946.GB7267@brian-ubuntu \
    --to=computersforpeace@gmail.com \
    --cc=alior@marvell.com \
    --cc=dedekind1@gmail.com \
    --cc=dwmw2@infradead.org \
    --cc=ezequiel.garcia@free-electrons.com \
    --cc=gregory.clement@free-electrons.com \
    --cc=jason@lakedaemon.net \
    --cc=linux-mtd@lists.infradead.org \
    --cc=thomas.petazzoni@free-electrons.com \
    --cc=w@1wt.eu \
    --cc=zonque@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox