From: Dan Carpenter <dan.carpenter@oracle.com>
To: Huang Shijie <b32955@freescale.com>
Cc: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>,
kernel-janitors@vger.kernel.org,
Matthieu CASTET <matthieu.castet@parrot.com>,
linux-mtd@lists.infradead.org,
Brian Norris <computersforpeace@gmail.com>,
David Woodhouse <dwmw2@infradead.org>
Subject: Re: [patch] mtd: nand: silence some shift wrap warnings
Date: Tue, 13 Aug 2013 09:35:33 +0300 [thread overview]
Message-ID: <20130813063533.GP5502@mwanda> (raw)
In-Reply-To: <5209D0C6.5070307@freescale.com>
On Tue, Aug 13, 2013 at 02:23:02PM +0800, Huang Shijie wrote:
> 于 2013年08月09日 17:49, Dan Carpenter 写道:
> >There are static checkers which complain when we declare variables as
>
> could you tell me which "checker" and how do you test it?
>
> you'd better post the warning message here.
>
It's some stuff I'm working on but haven't released yet. But "len"
and "ofs" are declared as u64 and loff_t. If they were declared as
unsigned long then maybe the current code would be fine because the
code would be correct-ish on 32 bit arches.
So this is definitely the right thing to do.
regards,
dan carpenter
next prev parent reply other threads:[~2013-08-13 6:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-09 9:49 [patch] mtd: nand: silence some shift wrap warnings Dan Carpenter
2013-08-13 6:23 ` Huang Shijie
2013-08-13 6:35 ` Dan Carpenter [this message]
2013-08-13 7:31 ` Brian Norris
2013-08-16 14:55 ` Artem Bityutskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130813063533.GP5502@mwanda \
--to=dan.carpenter@oracle.com \
--cc=artem.bityutskiy@linux.intel.com \
--cc=b32955@freescale.com \
--cc=computersforpeace@gmail.com \
--cc=dwmw2@infradead.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=matthieu.castet@parrot.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox