From: Brian Norris <computersforpeace@gmail.com>
To: Pekon Gupta <pekon@ti.com>
Cc: mugunthanvnm@ti.com, arnd@arndb.de, dedekind1@gmail.com,
tony@atomide.com, avinashphilipk@gmail.com, balbi@ti.com,
devicetree@vger.kernel.org, linux-mtd@lists.infradead.org,
olof@lixom.net, benoit.cousson@linaro.org,
linux-omap@vger.kernel.org, dwmw2@infradead.org
Subject: Re: [PATCH v5 0/4] mtd:nand:omap2: clean-up of supported ECC schemes
Date: Tue, 20 Aug 2013 18:32:55 -0700 [thread overview]
Message-ID: <20130821013255.GD28382@ld-irv-0074.broadcom.com> (raw)
In-Reply-To: <1373748891-7779-1-git-send-email-pekon@ti.com>
Hi Pekon,
I don't think I will take this series (at least not yet), because of the
device-tree ABI breakage.
On Sun, Jul 14, 2013 at 02:24:47AM +0530, Pekon Gupta wrote:
>
> Changes v4 -> v5
> - Rebased to linux-next
> IMPORTANT: Need to revert commit fb1585b, [PATCH 2/4] part of previous version
> http://lists.infradead.org/pipermail/linux-mtd/2013-July/047441.html
>
> - Swapped PATCH-1 & PATCH-2 to maintain bisectibility & compilation dependency
> http://lists.infradead.org/pipermail/linux-mtd/2013-July/047461.html
>
> - PATCH-2: re-ordered call to is_elm_present() for later updates ELM driver
> - dropped changes in include/linux/platform_data/elm.h (not needed)
> - PATCH-3: re-ordered call to is_elm_present() for later updates ELM driver
> - Re-formated patch description (replaced tabs with white-spaces)
>
>
> Changes v3 -> v4
> (Resent with CC: devicetree-discuss@lists.ozlabs.org)
Make sure to use devicetree@vger.kernel.org for future series.
> - [Patch 1/3] removed MTD_NAND_OMAP_BCH8 & MTD_NAND_OMAP_BCH4 from nand/Kconfig
> ECC scheme selectable via nand DT (nand-ecc-opt).
> - [*] rebased for l2-mtd.git
>
>
> Changes v2 -> v3
> (Resent with Author Name fixed)
> - PATCH-1: re-arranged code to remove redundancy, added NAND_BUSWIDTH_AUTO
> - PATCH-2: updated nand-ecc-opt DT mapping and Documentation
> - PATCH-3: code-cleaning + changes to match PATCH-1
> - PATCH-4 <DROPPED> update DT attribute for ti,nand-ecc-opt
> - received feedback to keep DT mapping independent of linuxism
> - PATCH-4:<NEW> : ARM: dts: AM33xx: updated default ECC scheme in nand-ecc-opt
> - independent patch for AM335x-evm.dts update based on PATCH-2
>
>
> Changes v1 -> v2
> added [PATCH 3/4] and [PATCH 4/4]
[...]
You might also consider a future patch for utilizing devm_* functions
for the probe/remove routines in drivers/mtd/nand/omap2.c. That could
improve some of the stuff I looked at in this series.
Brian
next prev parent reply other threads:[~2013-08-21 1:33 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-13 20:54 [PATCH v5 0/4] mtd:nand:omap2: clean-up of supported ECC schemes Pekon Gupta
2013-07-13 20:54 ` [PATCH v5 1/4] ARM: OMAP2+: cleaned-up DT support of various " Pekon Gupta
2013-08-21 1:26 ` Brian Norris
2013-08-22 4:54 ` Olof Johansson
2013-08-22 7:56 ` Gupta, Pekon
2013-08-27 17:04 ` Olof Johansson
2013-09-12 11:57 ` Gupta, Pekon
2013-07-13 20:54 ` [PATCH v5 2/4] mtd:nand:omap2: clean-up BCHx_HW and BCHx_SW ECC configurations in device_probe Pekon Gupta
2013-08-21 1:26 ` Brian Norris
2013-07-13 20:54 ` [PATCH v5 3/4] mtd:nand:omap2: updated support for BCH4 ECC scheme Pekon Gupta
2013-07-13 20:54 ` [PATCH v5 4/4] ARM: dts: AM33xx: updated default ECC scheme in nand-ecc-opt Pekon Gupta
2013-07-13 21:13 ` [PATCH v5 0/4] mtd:nand:omap2: clean-up of supported ECC schemes Gupta, Pekon
2013-08-20 13:20 ` Gupta, Pekon
2013-08-20 14:02 ` Artem Bityutskiy
2013-08-20 18:17 ` Brian Norris
2013-08-21 1:32 ` Brian Norris [this message]
2013-09-12 12:02 ` Gupta, Pekon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130821013255.GD28382@ld-irv-0074.broadcom.com \
--to=computersforpeace@gmail.com \
--cc=arnd@arndb.de \
--cc=avinashphilipk@gmail.com \
--cc=balbi@ti.com \
--cc=benoit.cousson@linaro.org \
--cc=dedekind1@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=dwmw2@infradead.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=mugunthanvnm@ti.com \
--cc=olof@lixom.net \
--cc=pekon@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox