From: Marek Vasut <marex@denx.de>
To: Brian Norris <computersforpeace@gmail.com>
Cc: linux-mtd@lists.infradead.org,
Michel Stempin <michel.stempin@wanadoo.fr>
Subject: Re: [RESEND][PATCH] mtd: chips: Add support for PMC SPI Flash chips in m25p80.c
Date: Wed, 21 Aug 2013 10:07:17 +0200 [thread overview]
Message-ID: <201308211007.18051.marex@denx.de> (raw)
In-Reply-To: <20130821075903.GC31788@brian-ubuntu>
Dear Brian Norris,
> On Wed, Aug 21, 2013 at 09:41:38AM +0200, Marek Vasut wrote:
> > Dear Brian Norris,
> >
> > > + Marek, since he's been reviewing (with dismay?) the increase in macro
> > > flags in this driver. If there are any objections, I can amend/drop the
> > > patch.
> >
> > Hmmm ... this SECT_4K_PMC seems too combined to me. Why don't we use the
> > SECT_4K flag and another flag to indicate it's a PMC part? Even better,
> > I recall you can
>
> Separating manufacturer from SECT_4K sounds good, but it really doesn't
> buy us much. See my next comments.
I see, that's really bad news. Thanks for the explanation!
I guess there really is nothing much we can do about such parts. But then if we
take device tree probe into consideration, we might actually want to match the
part name to discern the PMS device. Or am I talking complete nonsense?
Best regards,
Marek Vasut
next prev parent reply other threads:[~2013-08-21 8:07 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-15 10:13 [RESEND][PATCH] mtd: chips: Add support for PMC SPI Flash chips in m25p80.c Michel Stempin
2013-08-21 7:27 ` Brian Norris
2013-08-21 7:41 ` Marek Vasut
2013-08-21 7:59 ` Brian Norris
2013-08-21 8:07 ` Marek Vasut [this message]
2013-08-21 8:30 ` Brian Norris
2013-08-21 13:10 ` Marek Vasut
2013-08-21 19:47 ` Brian Norris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201308211007.18051.marex@denx.de \
--to=marex@denx.de \
--cc=computersforpeace@gmail.com \
--cc=linux-mtd@lists.infradead.org \
--cc=michel.stempin@wanadoo.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox