Re: [PATCH V2] spi: dual and quad support(add single macro)

[Mark Brown <broonie@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 1147 bytes --]

On Thu, Aug 29, 2013 at 09:01:50AM +0800, wangyuhang wrote:

> fix two things in patch:
> commit id:f477b7fb13df2b843997559ff34e87d054ba6538

> 1.Add SPI_TX_SINGLE and SPI_RX_SINGLE to specify SINGLE mode.
>  Instead of using default value in mode.
> 2.Delete a "return" when commit the patch to a new kernel version
>  by mistake. So recover it.

These two changes aren't related to each other so should be sent as two
separate patches.

> @@ -89,8 +89,12 @@ struct spi_device {
>  #define	SPI_READY	0x80			/* slave pulls low to pause */
>  #define	SPI_TX_DUAL	0x100			/* transmit with 2 wires */
>  #define	SPI_TX_QUAD	0x200			/* transmit with 4 wires */
> +/* transmit with 1 wire(not using dual-tx and quad-tx) */
> +#define	SPI_TX_SINGLE	~(SPI_TX_DUAL | SPI_TX_QUAD)
>  #define	SPI_RX_DUAL	0x400			/* receive with 2 wires */
>  #define	SPI_RX_QUAD	0x800			/* receive with 4 wires */
> +/* receive with 1 wire(not using dual-rx and quad-rx) */
> +#define	SPI_RX_SINGLE	~(SPI_RX_DUAL | SPI_RX_QUAD)

These don't look right, they're going to set all bits which is going to
interfere with all the other flags.  Why do we need this define at all?

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]