From: Huang Shijie <shijie8@gmail.com>
To: David Woodhouse <dwmw2@infradead.org>
Cc: "Huang Shijie" <b32955@freescale.com>,
linux-mtd@lists.infradead.org,
"Artem Bityutskiy" <artem.bityutskiy@linux.intel.com>,
"Lothar Waßmann" <LW@KARO-electronics.de>
Subject: Re: [PATCH 04/25] mtd: nand: gpmi-nand: janitorial cleanup: (commas after last element of struct initializer)
Date: Sat, 31 Aug 2013 09:42:38 -0400 [thread overview]
Message-ID: <20130831134236.GB22069@gmail.com> (raw)
In-Reply-To: <1377879189.22372.65.camel@shinybook.infradead.org>
On Fri, Aug 30, 2013 at 05:13:09PM +0100, David Woodhouse wrote:
> On Thu, 2013-08-01 at 07:50 +0200, Lothar Waßmann wrote:
>
> Now, admittedly that's the *general* case, and the ones you've removed
> commas from are very unlikely to ever have new members added after them.
> Especially the one that's a NULL sentinel at the end of an ID match
> list. But I'm just not sure I approve of the concept of removing the
> commas. I'm happier with them present, and a general habit of including
> them.
Hi David:
thanks for explanations.
If you do not like this patch, you can remove it.
thanks
Huang Shijie
next prev parent reply other threads:[~2013-08-31 1:37 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1375279887-17928-1-git-send-email-LW@KARO-electronics.de>
2013-08-01 2:12 ` [PATCH 03/25] mtd: nand: gpmi-nand: let the driver core handle pinctrl Huang Shijie
[not found] ` <1375279887-17928-3-git-send-email-LW@KARO-electronics.de>
2013-08-01 2:13 ` [PATCH 05/25] mtd: nand: gpmi-nand: use more sensible error codes at various places Huang Shijie
[not found] ` <1375279887-17928-2-git-send-email-LW@KARO-electronics.de>
2013-08-01 2:15 ` [PATCH 04/25] mtd: nand: gpmi-nand: janitorial cleanup: (commas after last element of struct initializer) Huang Shijie
2013-08-01 5:50 ` Lothar Waßmann
2013-08-01 6:14 ` Huang Shijie
2013-08-06 15:13 ` Artem Bityutskiy
2013-08-07 6:09 ` [PATCH 03/25] mtd: nand: gpmi-nand: let the driver core handle pinctrl Lothar Waßmann
2013-08-07 6:09 ` [PATCH/RESEND 1/2] mtd: nand: gpmi-nand: janitorial cleanup: (commas after last element of struct initializer) Lothar Waßmann
2013-08-07 6:15 ` [PATCH/RESEND v2 0/2] mtd: nand: gpmi-nand: cleanup patches Lothar Waßmann
2013-08-07 6:31 ` Artem Bityutskiy
2013-08-07 6:15 ` [PATCH/RESEND 1/2] mtd: nand: gpmi-nand: janitorial cleanup: (commas after last element of struct initializer) Lothar Waßmann
2013-08-07 6:15 ` [PATCH/RESEND 2/2] mtd: nand: gpmi-nand: use more sensible error codes at various places Lothar Waßmann
2013-08-30 16:13 ` [PATCH 04/25] mtd: nand: gpmi-nand: janitorial cleanup: (commas after last element of struct initializer) David Woodhouse
2013-08-31 13:42 ` Huang Shijie [this message]
2013-09-02 6:14 ` Lothar Waßmann
2013-09-02 15:44 ` David Woodhouse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130831134236.GB22069@gmail.com \
--to=shijie8@gmail.com \
--cc=LW@KARO-electronics.de \
--cc=artem.bityutskiy@linux.intel.com \
--cc=b32955@freescale.com \
--cc=dwmw2@infradead.org \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox