From: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
To: linux-mtd@lists.infradead.org
Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>,
Lior Amsalem <alior@marvell.com>,
Tawfik Bayouk <tawfik@marvell.com>,
haojian.zhuang@gmail.com, Daniel Mack <zonque@gmail.com>,
b32955@freescale.com, matthieu.castet@parrot.com,
Gregory Clement <gregory.clement@free-electrons.com>,
Brian Norris <computersforpeace@gmail.com>,
Willy Tarreau <w@1wt.eu>
Subject: Setting NAND timings parameters (Re: [RFC/PATCH v2] mtd: nand: pxa3xx: Remove redundant device probing)
Date: Tue, 24 Sep 2013 18:46:54 -0300 [thread overview]
Message-ID: <20130924214653.GA2376@localhost> (raw)
In-Reply-To: <522F2941.4030406@gmail.com>
On Tue, Sep 10, 2013 at 04:14:25PM +0200, Daniel Mack wrote:
> >
> > Right. However, since we can easily add support to configure every controller
> > parameter (right?) this shouldn't be a problem.
> >
> > What do you think of this change, Daniel?
>
> I always thought that this detail of the pxa nand driver is ugly :) But
> I'd say before it can be merged, you need to provide code to set the
> timing from parameters obtained from generic part. Are you working on
> this? I'd happily test more patches.
>
Returning to this point: it seems we have two different cases: ONFI-compliant
devices and non-ONFI.
For the ONFI, we can have a timings parameter table with some index according
to the ONFI timing mode available or user-selected. This table could be
generic (as in Matthieu Castet patch [1]) or driver specific (as in
denali driver).
For the non-ONFI, we could just add platform data / device-tree bindings
to allow to user to set the timings.
[1] http://patchwork.ozlabs.org/patch/197506/
How does this sound?
--
Ezequiel García, Free Electrons
Embedded Linux, Kernel and Android Engineering
http://free-electrons.com
next prev parent reply other threads:[~2013-09-24 21:47 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-10 11:17 [RFC/PATCH v2] pxa3xx-nand: Remove custom device detection Ezequiel Garcia
2013-09-10 11:17 ` [RFC/PATCH v2] mtd: nand: pxa3xx: Remove redundant device probing Ezequiel Garcia
2013-09-10 13:46 ` Daniel Mack
2013-09-10 13:57 ` Ezequiel Garcia
2013-09-10 14:14 ` Daniel Mack
2013-09-10 14:21 ` Ezequiel Garcia
2013-09-24 21:46 ` Ezequiel Garcia [this message]
2013-11-26 23:17 ` Setting NAND timings parameters (Re: [RFC/PATCH v2] mtd: nand: pxa3xx: Remove redundant device probing) Brian Norris
2013-11-27 11:38 ` Ezequiel Garcia
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130924214653.GA2376@localhost \
--to=ezequiel.garcia@free-electrons.com \
--cc=alior@marvell.com \
--cc=b32955@freescale.com \
--cc=computersforpeace@gmail.com \
--cc=gregory.clement@free-electrons.com \
--cc=haojian.zhuang@gmail.com \
--cc=linux-mtd@lists.infradead.org \
--cc=matthieu.castet@parrot.com \
--cc=tawfik@marvell.com \
--cc=thomas.petazzoni@free-electrons.com \
--cc=w@1wt.eu \
--cc=zonque@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox