From: Brian Norris <computersforpeace@gmail.com>
To: Huang Shijie <b32955@freescale.com>
Cc: David Woodhouse <dwmw2@infradead.org>, linux-mtd@lists.infradead.org
Subject: Re: [PATCH] mtd: nand: correct extemded param page error handling
Date: Wed, 25 Sep 2013 12:33:18 -0700 [thread overview]
Message-ID: <20130925193318.GG23337@ld-irv-0074.broadcom.com> (raw)
In-Reply-To: <523E5D57.6040008@freescale.com>
On Sun, Sep 22, 2013 at 11:00:39AM +0800, Huang Shijie wrote:
> 于 2013年09月21日 03:44, Brian Norris 写道:
> > If the ONFI extended parameter page gives codeword_size == 0, the
> > extended ECC information is corrupt and should not be used. Currently,
> > we (correctly) avoid using the information, but we don't report the
> > error to the caller, so the caller doesn't know that we didn't
> > initialize ecc_strength_ds and ecc_step_ds. Now the caller can warn the
> > user that it does not have sufficient information.
> >
> > This also removes the false and useless "ONFI extended param page
> > detected" debug message (it was printed even on the aforementioned
> > corruption, and for the success case, we don't really want a print).
> >
> > Signed-off-by: Brian Norris <computersforpeace@gmail.com>
> > Cc: Huang Shijie <b32955@freescale.com>
...
> Acked-by: Huang Shijie <b32955@freescale.com>
Pushed to l2-mtd.git.
Brian
prev parent reply other threads:[~2013-09-25 19:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-20 19:44 [PATCH] mtd: nand: correct extemded param page error handling Brian Norris
2013-09-22 3:00 ` Huang Shijie
2013-09-25 19:33 ` Brian Norris [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130925193318.GG23337@ld-irv-0074.broadcom.com \
--to=computersforpeace@gmail.com \
--cc=b32955@freescale.com \
--cc=dwmw2@infradead.org \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox