From: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
To: Daniel Mack <zonque@gmail.com>
Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>,
Lior Amsalem <alior@marvell.com>,
Tawfik Bayouk <tawfik@marvell.com>,
linux-mtd@lists.infradead.org,
Gregory Clement <gregory.clement@free-electrons.com>,
Brian Norris <computersforpeace@gmail.com>
Subject: Re: [PATCH 0/2] pxa3xx: Data buffer dynamic allocation
Date: Wed, 9 Oct 2013 11:03:13 -0300 [thread overview]
Message-ID: <20131009140312.GC31294@localhost> (raw)
In-Reply-To: <5255455C.6060606@gmail.com>
On Wed, Oct 09, 2013 at 02:00:28PM +0200, Daniel Mack wrote:
> On 09.10.2013 13:48, Ezequiel Garcia wrote:
> > On Fri, Oct 04, 2013 at 03:30:36PM -0300, Ezequiel Garcia wrote:
> >> As part of my work to support the NAND controllers in Armada 370/XP SoC
> >> here's a tiny set of patches to replace the currently data buffer allocation
> >> based in a hardcoded buffer size, into a dynamic scheme.
> >>
> >> We first use kmalloc to request a 256 bytes (big enough for the ONFI paramater
> >> page) and then re-allocate (either with kmalloc or using DMA allocators) using
> >> the detected page size.
> >>
> >> The first patch is required to perform the initial NAND operations (READID
> >> and friends) using programmable I/O since the DMA buffers are not ready
> >> at such early stage.
> >>
> >> The second patch performs to actual dynamic allocation and it's exactly
> >> the same patch I sent a few weeks ago:
> >>
> >> http://patchwork.ozlabs.org/patch/275982/
> >>
> >> Daniel: Can you test these two If they look fine we can add them now,
> >> being an improvement to the driver pxa3xx beyond the Armada 370/XP effort.
> >
> > Daniel: sorry to bother, any luck testing this?
>
> Sorry for the delay, got other things to do lately ...
>
No problem, thanks for testing.
> I tested these two patches successfully on my board with both use_dma=0
> and =1. Nice :) You can take my
>
> Tested-by: Daniel Mack <zonque@gmail.com>
>
Good news! Brian: all yours :)
> I hope I can catch up with my pxa DMA cleanups very soon.
Indeed. BTW: I had some feedback on why the Armada 370/XP SoC can't
do DMA on the NAND, I'll reply to the older mail with the information.
--
Ezequiel García, Free Electrons
Embedded Linux, Kernel and Android Engineering
http://free-electrons.com
next prev parent reply other threads:[~2013-10-09 14:03 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-04 18:30 [PATCH 0/2] pxa3xx: Data buffer dynamic allocation Ezequiel Garcia
2013-10-04 18:30 ` [PATCH 1/2] mtd: nand: pxa3xx: Move DMA I/O enabling Ezequiel Garcia
2013-10-04 18:30 ` [PATCH 2/2] mtd: nand: pxa3xx: Allocate data buffer on detected flash size Ezequiel Garcia
2013-10-15 19:41 ` Brian Norris
2013-10-16 10:25 ` Ezequiel Garcia
2013-10-09 11:48 ` [PATCH 0/2] pxa3xx: Data buffer dynamic allocation Ezequiel Garcia
2013-10-09 12:00 ` Daniel Mack
2013-10-09 14:03 ` Ezequiel Garcia [this message]
2013-10-15 18:29 ` Ezequiel Garcia
2013-10-15 19:16 ` Brian Norris
2013-10-15 20:47 ` Brian Norris
2013-10-16 11:05 ` Ezequiel Garcia
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131009140312.GC31294@localhost \
--to=ezequiel.garcia@free-electrons.com \
--cc=alior@marvell.com \
--cc=computersforpeace@gmail.com \
--cc=gregory.clement@free-electrons.com \
--cc=linux-mtd@lists.infradead.org \
--cc=tawfik@marvell.com \
--cc=thomas.petazzoni@free-electrons.com \
--cc=zonque@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).