From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ie0-x233.google.com ([2607:f8b0:4001:c03::233]) by merlin.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1VWA7J-0002Ac-Vv for linux-mtd@lists.infradead.org; Tue, 15 Oct 2013 19:17:18 +0000 Received: by mail-ie0-f179.google.com with SMTP id aq17so13959678iec.38 for ; Tue, 15 Oct 2013 12:16:56 -0700 (PDT) Date: Tue, 15 Oct 2013 12:16:52 -0700 From: Brian Norris To: Ezequiel Garcia Subject: Re: [PATCH 0/2] pxa3xx: Data buffer dynamic allocation Message-ID: <20131015191652.GU23337@ld-irv-0074.broadcom.com> References: <1380911438-24240-1-git-send-email-ezequiel.garcia@free-electrons.com> <20131009114803.GA31294@localhost> <5255455C.6060606@gmail.com> <20131009140312.GC31294@localhost> <20131015182903.GA2454@localhost> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20131015182903.GA2454@localhost> Cc: Thomas Petazzoni , Lior Amsalem , Tawfik Bayouk , Daniel Mack , linux-mtd@lists.infradead.org, Gregory Clement List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Hi Ezequiel, On Tue, Oct 15, 2013 at 03:29:04PM -0300, Ezequiel Garcia wrote: > On Wed, Oct 09, 2013 at 11:03:13AM -0300, Ezequiel Garcia wrote: > > On Wed, Oct 09, 2013 at 02:00:28PM +0200, Daniel Mack wrote: > > > On 09.10.2013 13:48, Ezequiel Garcia wrote: > > > > On Fri, Oct 04, 2013 at 03:30:36PM -0300, Ezequiel Garcia wrote: > > > >> As part of my work to support the NAND controllers in Armada 370/XP SoC > > > >> here's a tiny set of patches to replace the currently data buffer allocation > > > >> based in a hardcoded buffer size, into a dynamic scheme. > > > >> > > > >> We first use kmalloc to request a 256 bytes (big enough for the ONFI paramater > > > >> page) and then re-allocate (either with kmalloc or using DMA allocators) using > > > >> the detected page size. > > > >> > > > >> The first patch is required to perform the initial NAND operations (READID > > > >> and friends) using programmable I/O since the DMA buffers are not ready > > > >> at such early stage. > > > >> > > > >> The second patch performs to actual dynamic allocation and it's exactly > > > >> the same patch I sent a few weeks ago: > > > >> > > > >> http://patchwork.ozlabs.org/patch/275982/ > > > >> > > > >> Daniel: Can you test these two If they look fine we can add them now, > > > >> being an improvement to the driver pxa3xx beyond the Armada 370/XP effort. > > > > > > > > Daniel: sorry to bother, any luck testing this? > > > > > > Sorry for the delay, got other things to do lately ... > > > > > > > No problem, thanks for testing. > > > > > I tested these two patches successfully on my board with both use_dma=0 > > > and =1. Nice :) You can take my > > > > > > Tested-by: Daniel Mack > > > > > > > Good news! Brian: all yours :) > > > > Brian: any chance you pick these two soon? :-) I think I overlooked these once your other gigantic patch set came. I'll take a look at them now. Brian