From: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
To: Brian Norris <computersforpeace@gmail.com>
Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>,
Lior Amsalem <alior@marvell.com>, Daniel Mack <zonque@gmail.com>,
linux-mtd@lists.infradead.org,
Gregory Clement <gregory.clement@free-electrons.com>,
David Woodhouse <dwmw2@infradead.org>, Willy Tarreau <w@1wt.eu>
Subject: Re: [PATCH] mtd: nand: pxa3xx: Fix registered MTD name
Date: Fri, 18 Oct 2013 06:33:17 -0300 [thread overview]
Message-ID: <20131018093316.GA18998@localhost> (raw)
In-Reply-To: <20131018013618.GI23337@ld-irv-0074.broadcom.com>
On Thu, Oct 17, 2013 at 06:36:18PM -0700, Brian Norris wrote:
> On Thu, Oct 17, 2013 at 06:24:57AM -0300, Ezequiel Garcia wrote:
> > In a recent commit:
> >
> > commit f455578dd961087a5cf94730d9f6489bb1d355f0
> > Author: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
> > Date: Mon Aug 12 14:14:53 2013 -0300
> >
> > mtd: nand: pxa3xx: Remove hardcoded mtd name
> >
> > There's no advantage in using a hardcoded name for the mtd device.
> > Instead use the provided by the platform_device.
> >
> > The MTD name was changed to use the one provided by the platform_device.
> > However, this can be problematic as some users want to set partitions
> > using the kernel parameter 'mtdpart', where the name is needed.
> >
> > For that reason, using a simpler and easier to remember name such
> > as 'pxa3xx-nand' is certainly a better choice.
>
> Hmm, if we're really interested in the user experience of 'mtdparts'
> users, shouldn't we just revert to the old name ("pxa3xx_nand-0") to
> avoid breaking systems? Or are there no users that would care?
>
Dammit! yes, that's the intention of this patch: revert to the old name
"pxa3xx_nand-0" to avoid breaking systems.
Guess I couldn't manage my OCD and picked a more appealing name :)
I'll send a v2 right away.
--
Ezequiel García, Free Electrons
Embedded Linux, Kernel and Android Engineering
http://free-electrons.com
prev parent reply other threads:[~2013-10-18 9:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-17 9:24 [PATCH] mtd: nand: pxa3xx: Fix registered MTD name Ezequiel Garcia
2013-10-18 1:36 ` Brian Norris
2013-10-18 9:33 ` Ezequiel Garcia [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131018093316.GA18998@localhost \
--to=ezequiel.garcia@free-electrons.com \
--cc=alior@marvell.com \
--cc=computersforpeace@gmail.com \
--cc=dwmw2@infradead.org \
--cc=gregory.clement@free-electrons.com \
--cc=linux-mtd@lists.infradead.org \
--cc=thomas.petazzoni@free-electrons.com \
--cc=w@1wt.eu \
--cc=zonque@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).