* [PATCH] mtd: nand: pxa3xx: Fix registered MTD name
@ 2013-10-17 9:24 Ezequiel Garcia
2013-10-18 1:36 ` Brian Norris
0 siblings, 1 reply; 3+ messages in thread
From: Ezequiel Garcia @ 2013-10-17 9:24 UTC (permalink / raw)
To: linux-mtd
Cc: Thomas Petazzoni, Lior Amsalem, Daniel Mack, Ezequiel Garcia,
Gregory Clement, Brian Norris, David Woodhouse, Willy Tarreau
In a recent commit:
commit f455578dd961087a5cf94730d9f6489bb1d355f0
Author: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
Date: Mon Aug 12 14:14:53 2013 -0300
mtd: nand: pxa3xx: Remove hardcoded mtd name
There's no advantage in using a hardcoded name for the mtd device.
Instead use the provided by the platform_device.
The MTD name was changed to use the one provided by the platform_device.
However, this can be problematic as some users want to set partitions
using the kernel parameter 'mtdpart', where the name is needed.
For that reason, using a simpler and easier to remember name such
as 'pxa3xx-nand' is certainly a better choice.
Signed-off-by: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
---
drivers/mtd/nand/pxa3xx_nand.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/mtd/nand/pxa3xx_nand.c b/drivers/mtd/nand/pxa3xx_nand.c
index aa75adf..6ec3810 100644
--- a/drivers/mtd/nand/pxa3xx_nand.c
+++ b/drivers/mtd/nand/pxa3xx_nand.c
@@ -46,6 +46,8 @@
*/
#define INIT_BUFFER_SIZE 256
+#define DRIVER_NAME "pxa3xx-nand"
+
/* registers and bit definitions */
#define NDCR (0x00) /* Control register */
#define NDTR0CS0 (0x04) /* Timing Parameter 0 for CS0 */
@@ -1339,7 +1341,7 @@ static int pxa3xx_nand_probe(struct platform_device *pdev)
for (cs = 0; cs < pdata->num_cs; cs++) {
struct mtd_info *mtd = info->host[cs]->mtd;
- mtd->name = pdev->name;
+ mtd->name = DRIVER_NAME;
info->cs = cs;
ret = pxa3xx_nand_scan(mtd);
if (ret) {
@@ -1425,7 +1427,7 @@ static int pxa3xx_nand_resume(struct platform_device *pdev)
static struct platform_driver pxa3xx_nand_driver = {
.driver = {
- .name = "pxa3xx-nand",
+ .name = DRIVER_NAME,
.of_match_table = pxa3xx_nand_dt_ids,
},
.probe = pxa3xx_nand_probe,
--
1.8.1.5
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] mtd: nand: pxa3xx: Fix registered MTD name
2013-10-17 9:24 [PATCH] mtd: nand: pxa3xx: Fix registered MTD name Ezequiel Garcia
@ 2013-10-18 1:36 ` Brian Norris
2013-10-18 9:33 ` Ezequiel Garcia
0 siblings, 1 reply; 3+ messages in thread
From: Brian Norris @ 2013-10-18 1:36 UTC (permalink / raw)
To: Ezequiel Garcia
Cc: Thomas Petazzoni, Lior Amsalem, Daniel Mack, linux-mtd,
Gregory Clement, David Woodhouse, Willy Tarreau
On Thu, Oct 17, 2013 at 06:24:57AM -0300, Ezequiel Garcia wrote:
> In a recent commit:
>
> commit f455578dd961087a5cf94730d9f6489bb1d355f0
> Author: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
> Date: Mon Aug 12 14:14:53 2013 -0300
>
> mtd: nand: pxa3xx: Remove hardcoded mtd name
>
> There's no advantage in using a hardcoded name for the mtd device.
> Instead use the provided by the platform_device.
>
> The MTD name was changed to use the one provided by the platform_device.
> However, this can be problematic as some users want to set partitions
> using the kernel parameter 'mtdpart', where the name is needed.
>
> For that reason, using a simpler and easier to remember name such
> as 'pxa3xx-nand' is certainly a better choice.
Hmm, if we're really interested in the user experience of 'mtdparts'
users, shouldn't we just revert to the old name ("pxa3xx_nand-0") to
avoid breaking systems? Or are there no users that would care?
Brian
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] mtd: nand: pxa3xx: Fix registered MTD name
2013-10-18 1:36 ` Brian Norris
@ 2013-10-18 9:33 ` Ezequiel Garcia
0 siblings, 0 replies; 3+ messages in thread
From: Ezequiel Garcia @ 2013-10-18 9:33 UTC (permalink / raw)
To: Brian Norris
Cc: Thomas Petazzoni, Lior Amsalem, Daniel Mack, linux-mtd,
Gregory Clement, David Woodhouse, Willy Tarreau
On Thu, Oct 17, 2013 at 06:36:18PM -0700, Brian Norris wrote:
> On Thu, Oct 17, 2013 at 06:24:57AM -0300, Ezequiel Garcia wrote:
> > In a recent commit:
> >
> > commit f455578dd961087a5cf94730d9f6489bb1d355f0
> > Author: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
> > Date: Mon Aug 12 14:14:53 2013 -0300
> >
> > mtd: nand: pxa3xx: Remove hardcoded mtd name
> >
> > There's no advantage in using a hardcoded name for the mtd device.
> > Instead use the provided by the platform_device.
> >
> > The MTD name was changed to use the one provided by the platform_device.
> > However, this can be problematic as some users want to set partitions
> > using the kernel parameter 'mtdpart', where the name is needed.
> >
> > For that reason, using a simpler and easier to remember name such
> > as 'pxa3xx-nand' is certainly a better choice.
>
> Hmm, if we're really interested in the user experience of 'mtdparts'
> users, shouldn't we just revert to the old name ("pxa3xx_nand-0") to
> avoid breaking systems? Or are there no users that would care?
>
Dammit! yes, that's the intention of this patch: revert to the old name
"pxa3xx_nand-0" to avoid breaking systems.
Guess I couldn't manage my OCD and picked a more appealing name :)
I'll send a v2 right away.
--
Ezequiel García, Free Electrons
Embedded Linux, Kernel and Android Engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-10-18 9:33 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-10-17 9:24 [PATCH] mtd: nand: pxa3xx: Fix registered MTD name Ezequiel Garcia
2013-10-18 1:36 ` Brian Norris
2013-10-18 9:33 ` Ezequiel Garcia
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).