From: Brian Norris <computersforpeace@gmail.com>
To: Huang Shijie <b32955@freescale.com>,
David Woodhouse <dwmw2@infradead.org>
Cc: tharvey@gateworks.com, linux-mtd@lists.infradead.org,
stable@vger.kernel.org, dedekind1@gmail.com
Subject: Re: [PATCH v2 fix] mtd: gpmi: fix the ecc regression
Date: Thu, 24 Oct 2013 15:19:20 -0700 [thread overview]
Message-ID: <20131024221920.GF20061@ld-irv-0074.broadcom.com> (raw)
In-Reply-To: <1382604496-28118-1-git-send-email-b32955@freescale.com>
On Thu, Oct 24, 2013 at 04:48:16PM +0800, Huang Shijie wrote:
> The legacy ecc layout is to use all the OOB area by computing the ecc strength
> and ecc step size ourselves.
>
> The patch "2febcdf mtd: gpmi: set the BCHs geometry with the ecc info"
> makes the gpmi to use the ECC info(ecc strength and ecc step size)
> provided by the MTD code, and creates a different NAND ecc layout
> for the BCH , and use the new ecc layout, this brings a regression to us:
> We can not mount the ubifs which was created by the old NAND ecc layout.
>
> This patch fixes this issue by use the legacy ecc layout firstly, if it fails
> we try to use the new ecc layout.
>
> Signed-off-by: Huang Shijie <b32955@freescale.com>
> Cc: stable@vger.kernel.org
I fixed up the language a little, dropped the 'stable', and pushed to
linux-mtd.git (in hopes of sending another pull request for 3.12). I'll
see if David wants to weigh in first.
Feel free to send your updated DT binding patch(es).
Brian
next prev parent reply other threads:[~2013-10-24 22:19 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-24 8:14 [PATCH V2] mtd: gpmi: fix the ecc regression Huang Shijie
2013-10-24 8:48 ` [PATCH v2 fix] " Huang Shijie
2013-10-24 22:19 ` Brian Norris [this message]
2013-10-25 13:36 ` David Woodhouse
2013-10-25 12:03 ` [PATCH V2] " David Woodhouse
2013-10-25 12:20 ` David Woodhouse
2013-10-25 13:22 ` Marek
2013-10-26 1:33 ` Huang Shijie
2013-10-25 13:29 ` David Woodhouse
2013-10-25 13:38 ` Marek
2013-10-26 1:41 ` Huang Shijie
2013-10-25 14:08 ` David Woodhouse
2013-10-25 17:08 ` Brian Norris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131024221920.GF20061@ld-irv-0074.broadcom.com \
--to=computersforpeace@gmail.com \
--cc=b32955@freescale.com \
--cc=dedekind1@gmail.com \
--cc=dwmw2@infradead.org \
--cc=linux-mtd@lists.infradead.org \
--cc=stable@vger.kernel.org \
--cc=tharvey@gateworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox