From mboxrd@z Thu Jan  1 00:00:00 1970
Date: Mon, 4 Nov 2013 08:58:21 -0300
From: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
To: Huang Shijie <shijie8@gmail.com>
Subject: Re: [PATCH v2 08/27] mtd: nand: pxa3xx: Use chip->cmdfunc instead of
 the internal
Message-ID: <20131104115820.GB2516@localhost>
References: <1382137374-21251-1-git-send-email-ezequiel.garcia@free-electrons.com>
 <1382137374-21251-9-git-send-email-ezequiel.garcia@free-electrons.com>
 <20131103213237.GB5896@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20131103213237.GB5896@gmail.com>
Cc: Lior Amsalem <alior@marvell.com>,
 Thomas Petazzoni <thomas.petazzoni@free-electrons.com>,
 Jason Cooper <jason@lakedaemon.net>, Tawfik Bayouk <tawfik@marvell.com>,
 Daniel Mack <zonque@gmail.com>, linux-mtd@lists.infradead.org,
 Gregory Clement <gregory.clement@free-electrons.com>,
 Brian Norris <computersforpeace@gmail.com>, Willy Tarreau <w@1wt.eu>,
 linux-arm-kernel@lists.infradead.org
List-Id: Linux MTD discussion mailing list <linux-mtd.lists.infradead.org>
List-Unsubscribe: <http://lists.infradead.org/mailman/options/linux-mtd>,
 <mailto:linux-mtd-request@lists.infradead.org?subject=unsubscribe>
List-Archive: <http://lists.infradead.org/pipermail/linux-mtd/>
List-Post: <mailto:linux-mtd@lists.infradead.org>
List-Help: <mailto:linux-mtd-request@lists.infradead.org?subject=help>
List-Subscribe: <http://lists.infradead.org/mailman/listinfo/linux-mtd>,
 <mailto:linux-mtd-request@lists.infradead.org?subject=subscribe>

On Sun, Nov 03, 2013 at 04:32:40PM -0500, Huang Shijie wrote:
> On Fri, Oct 18, 2013 at 08:02:35PM -0300, Ezequiel Garcia wrote:
> > @@ -1011,14 +1011,16 @@ static void pxa3xx_nand_free_buff(struct pxa3xx_nand_info *info)
> >  static int pxa3xx_nand_sensing(struct pxa3xx_nand_info *info)
> >  {
> >  	struct mtd_info *mtd;
> > +	struct nand_chip *chip;
> >  	int ret;
> Please add a empty line here.
> 

Sure, I will.

> >  	mtd = info->host[info->cs]->mtd;
> > +	chip = mtd->priv;
> >  	/* use the common timing to make a try */
> >  	ret = pxa3xx_nand_config_flash(info, &builtin_flash_types[0]);
> >  	if (ret)
> >  		return ret;
> >  
> > -	pxa3xx_nand_cmdfunc(mtd, NAND_CMD_RESET, 0, 0);
> > +	chip->cmdfunc(mtd, NAND_CMD_RESET, 0, 0);
> >  	if (info->is_ready)
> >  		return 0;
> Reviewed-by: Huang Shijie <shijie8@gmail.com>

Thanks!
-- 
Ezequiel García, Free Electrons
Embedded Linux, Kernel and Android Engineering
http://free-electrons.com