From mboxrd@z Thu Jan 1 00:00:00 1970 Date: Wed, 6 Nov 2013 16:16:23 -0300 From: Ezequiel Garcia To: linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 0/3] omap2: Assorted GPMC cleanups Message-ID: <20131106191622.GA3162@localhost> References: <1382921508-5104-1-git-send-email-ezequiel.garcia@free-electrons.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1382921508-5104-1-git-send-email-ezequiel.garcia@free-electrons.com> Cc: Javier Martinez Canillas , Enric Balletbo Serra , Jon Hunter , Tony Lindgren , linux-mtd@lists.infradead.org, Pekon Gupta List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Sun, Oct 27, 2013 at 09:51:45PM -0300, Ezequiel Garcia wrote: > (I'm CCing the MTD list, because GPMC is the memory controller > used for NOR, NAND and OneNAND devices). > > Hi all, > > Just a small patchset containing two small cleanups and a minor fix > for the GPMC memory controller. The first two are cleanups and can > be considered as preparation work for the fix. > > The fix is patch 3/3: "Move legacy GPMC width setting". It makes > explicit use of the DT property "gpmc,device-width" and removes the > subsequent (and redundant) setting of the GPMC width, based in the > NAND bus widht. > > Tested in AM335x (using DT) so I'd appreciate if someone can test using > a board-file, on a device with NAND flash. > > Jon: If you happen to read this, I'd like if you could take a look at > patch 1/3, since you were the last to touch that part of the code. > > Thanks! > > Ezequiel Garcia (3): > omap2: gpmc: Move initialization outside the gpmc_t condition > omap2: gpmc: Introduce gpmc_set_legacy() > omap2: gpmc: Move legacy GPMC width setting > > arch/arm/mach-omap2/gpmc-nand.c | 50 +++++++++++++++++++++++------------------ > 1 file changed, 28 insertions(+), 22 deletions(-) > Any comments about this? Pekon? Maybe you can comment or otherwise ack the patches? Thanks! -- Ezequiel GarcĂ­a, Free Electrons Embedded Linux, Kernel and Android Engineering http://free-electrons.com