From: Brian Norris <computersforpeace@gmail.com>
To: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
Cc: linux-mtd@lists.infradead.org
Subject: Re: [PATCH] mtd: nand: pxa3xx: make ECC configuration checks more explicit
Date: Mon, 18 Nov 2013 09:33:14 -0800 [thread overview]
Message-ID: <20131118173314.GY9468@ld-irv-0074.broadcom.com> (raw)
In-Reply-To: <20131117045704.GA17731@localhost>
On Sun, Nov 17, 2013 at 01:57:05AM -0300, Ezequiel Garcia wrote:
> On Thu, Nov 14, 2013 at 03:18:28PM -0800, Brian Norris wrote:
> > The Armada BCH configuration in this driver uses one of the two
> > following ECC schemes:
> >
> > 16-bit correction per 2048 bytes
> > 16-bit correction per 1024 bytes
> >
> > These are sufficient for mapping to the 4-bit per 512-bytes and 8-bit
> > per 512-bytes (respectively) minimum correctability requirements of many
> > common NAND.
> >
> > The current code only checks for the required strength (4-bit or 8-bit)
> > without checking the ECC step size that is associated with that strength
> > (and simply assumes it is 512). While that is often a safe assumption to
> > make, let's make it explicit, since we have that information.
> >
> > Signed-off-by: Brian Norris <computersforpeace@gmail.com>
>
> Acked-by: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
Pushed to l2-mtd.git/next.
Brian
prev parent reply other threads:[~2013-11-18 17:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-14 23:18 [PATCH] mtd: nand: pxa3xx: make ECC configuration checks more explicit Brian Norris
2013-11-17 4:57 ` Ezequiel Garcia
2013-11-18 17:33 ` Brian Norris [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131118173314.GY9468@ld-irv-0074.broadcom.com \
--to=computersforpeace@gmail.com \
--cc=ezequiel.garcia@free-electrons.com \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox