Re: [PATCH 1/2] mtd: Add NAND device drivers to MAINTAINERS

[Ezequiel Garcia <ezequiel.garcia@free-electrons.com>]

On Thu, Nov 21, 2013 at 10:53:14AM -0800, Brian Norris wrote:
> On Wed, Nov 20, 2013 at 09:20:08AM -0300, Ezequiel Garcia wrote:
> > Add drivers/mtd/nand/ to MAINTAINERS file with Brian Norris
> > as the subsystem maintainer.
> > 
> > Cc: Brian Norris <computersforpeace@gmail.com>
> > Cc: David Woodhouse <dwmw2@infradead.org>
> > Signed-off-by: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
> > ---
> >  MAINTAINERS | 12 ++++++++++++
> >  1 file changed, 12 insertions(+)
> > 
> > diff --git a/MAINTAINERS b/MAINTAINERS
> > index 167e188..d4145f7 100644
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -5554,6 +5554,18 @@ F:	drivers/mtd/
> >  F:	include/linux/mtd/
> >  F:	include/uapi/mtd/
> >  
> > +NAND DEVICE DRIVERS
> 
> While it would be nice for MTD and NAND to be listed together, I think
> this file is in alphabetical order ("NAND" doesn't come between "MTD"
> and "MEN").
> 

Right, I haven't noticed order.

> Also, I might recommend including "FLASH" in the title: NAND FLASH
> DEVICE DRIVERS.
> 

Sure...

> > +M:	Brian Norris <computersforpeace@gmail.com>
> > +L:	linux-mtd@lists.infradead.org
> > +W:	http://www.linux-mtd.infradead.org/
> > +Q:	http://patchwork.ozlabs.org/project/linux-mtd/list/
> > +T:	git http://git.infradead.org/l2-mtd.git
> 
> The git tree is an interesting case. l2-mtd.git was really only set up
> as a secondary tree, not as the official tree. It has moved to being the
> primary place for development, though, so your entry does reflect
> reality...
> 

Maybe create a new git repository, specially for this?

> > +S:	Maintained
> > +F:	drivers/mtd/nand/
> > +F:	include/linux/mtd/nand.h
> > +F:	include/linux/mtd/nand_ecc.h
> > +F:	include/linux/mtd/nand_bch.h
> 
> include/linux/mtd/nand*.h?
> include/linux/mtd/bbm.h?
> 

Yes, that's probably better.
-- 
Ezequiel García, Free Electrons
Embedded Linux, Kernel and Android Engineering
http://free-electrons.com