From: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
To: Brian Norris <computersforpeace@gmail.com>
Cc: Huang Shijie <b32955@freescale.com>,
David Woodhouse <dwmw2@infradead.org>,
linux-mtd@lists.infradead.org, Pekon Gupta <pekon@ti.com>
Subject: Re: [RFC/PATCH] mtd: nand: Refactor print messages
Date: Thu, 5 Dec 2013 07:32:59 -0300 [thread overview]
Message-ID: <20131205103259.GA2345@localhost> (raw)
In-Reply-To: <20131205020137.GH27149@ld-irv-0074.broadcom.com>
On Wed, Dec 04, 2013 at 06:01:37PM -0800, Brian Norris wrote:
> > diff --git a/drivers/mtd/nand/nand_base.c b/drivers/mtd/nand/nand_base.c
> > index bd39f7b..4bdc0df 100644
> > --- a/drivers/mtd/nand/nand_base.c
> > +++ b/drivers/mtd/nand/nand_base.c
> ...
> > @@ -3372,8 +3374,8 @@ static struct nand_flash_dev *nand_get_flash_type(struct mtd_info *mtd,
> > id_data[i] = chip->read_byte(mtd);
> >
> > if (id_data[0] != *maf_id || id_data[1] != *dev_id) {
> > - pr_info("%s: second ID read did not match "
> > - "%02x,%02x against %02x,%02x\n", __func__,
> > + pr_info("second ID read did not match "
> > + "%02x,%02x against %02x,%02x\n",
>
> scripts/checkpatch.pl and Documentation/CodingStyle don't like this long
> string (even though it would be over 80 chars). I think we should combine them.
>
You're right, user-visible strings shouldn't be splitted. The 80-char limit has
an exception about this (qouting Documentation/CodingStyle):
""
Chapter 2: Breaking long lines and strings
[..]
Statements longer than 80 columns will be broken into sensible chunks, unless
exceeding 80 columns significantly increases readability and does not hide
information. [..] However, never break user-visible strings such as printk
messages, because that breaks the ability to grep for them.
""
Regards!
--
Ezequiel García, Free Electrons
Embedded Linux, Kernel and Android Engineering
http://free-electrons.com
next prev parent reply other threads:[~2013-12-05 10:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-25 11:30 [RFC/PATCH] mtd: nand: Refactor print messages Ezequiel Garcia
2013-12-05 2:01 ` Brian Norris
2013-12-05 6:26 ` Gupta, Pekon
2013-12-05 10:32 ` Ezequiel Garcia [this message]
2013-12-09 19:41 ` Brian Norris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131205103259.GA2345@localhost \
--to=ezequiel.garcia@free-electrons.com \
--cc=b32955@freescale.com \
--cc=computersforpeace@gmail.com \
--cc=dwmw2@infradead.org \
--cc=linux-mtd@lists.infradead.org \
--cc=pekon@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).