public inbox for linux-mtd@lists.infradead.org
 help / color / mirror / Atom feed
From: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
To: Javier Martinez Canillas <javier@dowhile0.org>
Cc: "Thomas Petazzoni" <thomas.petazzoni@free-electrons.com>,
	"Brian Norris" <computersforpeace@gmail.com>,
	"Tony Lindgren" <tony@atomide.com>,
	"Enric Balletbo Serra" <eballetbo@gmail.com>,
	linux-mtd@lists.infradead.org, "Gupta, Pekon" <pekon@ti.com>,
	"Peter Meerwald" <pmeerw@pmeerw.net>,
	"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
	"Andreas Bießmann" <andreas.biessmann@corscience.de>
Subject: Re: OMAP3 NAND ECC selection
Date: Thu, 5 Dec 2013 15:26:29 -0300	[thread overview]
Message-ID: <20131205182628.GF2345@localhost> (raw)
In-Reply-To: <CABxcv=mtqkpyup0y-zv53YRvdgKH0bNXeCWf9mxPFoUTRQ=Gew@mail.gmail.com>

Hi Javier,

(CCing Brian: What do you think about this?)

On Thu, Dec 05, 2013 at 06:39:10PM +0100, Javier Martinez Canillas wrote:
> On Thu, Dec 5, 2013 at 6:13 PM, Tony Lindgren <tony@atomide.com> wrote:
> 
> In the another thread [0] pointed out by Enric we were discussing the
> same issue. Thomas suggested [1] that ideally we should be able to set
> a per MTD partition ECC scheme. That way we can set 1 bit hamming for
> the first MTD partition that has the SPL that the boot ROM needs to
> read and the other partitions can use a more secure ECC scheme. I
> completely agree with him.
> 
[..]
> global ECC scheme and we should expand the GPMC NAND DT binding so
> partitions support the "ti,nand-ecc-opt". I'll see if I can get some
> free time to try to implement that.
> 

AFAIK, there's no hardware limitation that would prevent us from setting
a per-partition ECC, keep in mind this effort is not reduced to make
devicetree accept ECC on the partitions.

While there are some per MTD device (which model each partition), the
ECC mode is present in the, nand_chip structure. My understanding is that
the NAND core hasn't been designed for this use case, and thus some
major re-work is needed to accomplish it.

Therefore, it's a much short-term solution to implement the OMAP
module parameter to fix the issue.

Of course, feel free to prove me wrong :-)
-- 
Ezequiel García, Free Electrons
Embedded Linux, Kernel and Android Engineering
http://free-electrons.com

  reply	other threads:[~2013-12-05 18:26 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-05  9:13 OMAP3 NAND ECC selection Peter Meerwald
2013-12-05  9:47 ` Enric Balletbo Serra
2013-12-05  9:59   ` Andreas Bießmann
2013-12-05 16:12     ` Peter Meerwald
2013-12-05 17:13       ` Tony Lindgren
2013-12-05 17:39         ` Javier Martinez Canillas
2013-12-05 18:26           ` Ezequiel Garcia [this message]
2013-12-05 18:58             ` Javier Martinez Canillas
2013-12-05 19:02             ` Gupta, Pekon
2013-12-05 19:06               ` Thomas Petazzoni
2013-12-05 19:24                 ` Brian Norris
2013-12-05 19:32                   ` Thomas Petazzoni
2013-12-05 19:38                     ` Tony Lindgren
2013-12-08 20:59                       ` Mike Dunn
2013-12-09  4:33                     ` Gupta, Pekon
2013-12-09 11:06                       ` Matthieu CASTET
2013-12-09 11:50                         ` Gupta, Pekon
2013-12-05 19:13             ` Brian Norris
2013-12-06 17:35         ` Andreas Bießmann
2013-12-06 14:54   ` Peter Meerwald

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131205182628.GF2345@localhost \
    --to=ezequiel.garcia@free-electrons.com \
    --cc=andreas.biessmann@corscience.de \
    --cc=computersforpeace@gmail.com \
    --cc=eballetbo@gmail.com \
    --cc=javier@dowhile0.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=pekon@ti.com \
    --cc=pmeerw@pmeerw.net \
    --cc=thomas.petazzoni@free-electrons.com \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox