From: Marek Vasut <marex@denx.de>
To: Sourav Poddar <sourav.poddar@ti.com>
Cc: devicetree@vger.kernel.org, linux-omap@vger.kernel.org,
balbi@ti.com, linux-spi@vger.kernel.org, broonie@kernel.org,
linux-mtd@lists.infradead.org, bcousson@baylibre.com,
computersforpeace@gmail.com, dwmw2@infradead.org
Subject: Re: [PATCHv2 00/10] Add memory mapped support for ti qspi, m25p80 serial flash.
Date: Wed, 11 Dec 2013 11:44:22 +0100 [thread overview]
Message-ID: <201312111144.23012.marex@denx.de> (raw)
In-Reply-To: <52A7E7A5.5000909@ti.com>
On Wednesday, December 11, 2013 at 05:18:45 AM, Sourav Poddar wrote:
> Hi Marek,
>
> On Tuesday 10 December 2013 06:19 PM, Marek Vasut wrote:
> > On Friday, December 06, 2013 at 03:24:41 PM, Sourav Poddar wrote:
> >> The patch series aims to add memory mapped support for TI qspi
> >> contoller and also add support for the same in serial flash
> >> driver(m25p80).
> >
> > My question is, shall we not wait for the new SPI NOR framework to be
> > well fleshed out and only then implement this controller driver on top
> > of it ?
>
> I think it will still take lot of time for spi framework to come to
> alignment
> and get merged in the mainline. Till then, m25p80 development should
> go on independently. Once, the spi framework is ready, I can myself port
> this into the new framework.
Sure, but I also think Huang is coming close to the new framework. Have you seen
his latest patchset ( Message-ID: <1386318764-15882-1-git-send-email-
b32955@freescale.com> ) ? I think you two should really start working on the new
framework instead of bending drivers all around.
> > I have a feeling this patchset adds quite a lot of ad-hoc hacks into the
> > m25p80 driver, which would become dead code once converted to the SPI
> > NOR framework.
>
> I dont think that spi framework till now provides capabilities which can
> be used
> to handle memory mapped cases.
Not yet, so please bring it up in the discussion there :)
> I did a quad mode support for m25p80 which easily got cloned into the
> new spi framework.
> Same can be done for the memory mapped support too
The quad mode didn't need any new hooks in the m25p80, did it ? That's the
difference here.
Best regards,
Marek Vasut
next prev parent reply other threads:[~2013-12-11 11:26 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-06 14:24 [PATCHv2 00/10] Add memory mapped support for ti qspi, m25p80 serial flash Sourav Poddar
2013-12-06 14:24 ` [PATCHv2 01/10] spi/spi.h: Add get_buf/put_buf support in spi master Sourav Poddar
2013-12-19 13:31 ` Mark Brown
2013-12-06 14:24 ` [PATCHv2 02/10] spi/qspi: parse register by name Sourav Poddar
2013-12-19 13:34 ` Mark Brown
2013-12-06 14:24 ` [PATCHv2 03/10] spi/qspi: Add support to switc to memory mapped operation Sourav Poddar
2013-12-10 12:54 ` Marek Vasut
2013-12-06 14:24 ` [PATCHv2 04/10] spi/qspi: configure set up register for memory map Sourav Poddar
2013-12-10 12:57 ` Marek Vasut
2013-12-10 17:13 ` Sourav Poddar
2013-12-06 14:24 ` [PATCHv2 05/10] spi/qspi: Add api for get_buf/put_buf Sourav Poddar
2013-12-10 12:58 ` Marek Vasut
2013-12-10 17:10 ` Sourav Poddar
2013-12-06 14:24 ` [PATCHv2 06/10] drivers: mtd: m25p80: Add api to configure master register Sourav Poddar
2013-12-06 14:24 ` [PATCHv2 07/10] drivers: mtd: m25p80: Adapt driver to support memory mapped read Sourav Poddar
2013-12-12 7:55 ` Huang Shijie
2013-12-12 8:15 ` Sourav Poddar
2013-12-12 8:31 ` Huang Shijie
2013-12-06 14:24 ` [PATCHv2 08/10] Documentation: bindings: ti-qspi: update binding information Sourav Poddar
2013-12-19 13:34 ` Mark Brown
2013-12-06 14:24 ` [PATCHv2 09/10] arm: dts: dra7: Add qspi device Sourav Poddar
2013-12-09 17:42 ` Tony Lindgren
2013-12-10 4:25 ` Sourav Poddar
2013-12-10 10:31 ` Mark Brown
2013-12-10 10:45 ` Sourav Poddar
2013-12-12 4:20 ` Sourav Poddar
2013-12-06 14:24 ` [PATCHv2 10/10] arm: dts: am43x-epos: " Sourav Poddar
2013-12-10 12:49 ` [PATCHv2 00/10] Add memory mapped support for ti qspi, m25p80 serial flash Marek Vasut
2013-12-10 16:11 ` Mark Brown
2013-12-10 18:22 ` Marek Vasut
2013-12-10 18:29 ` Mark Brown
2013-12-10 18:34 ` Marek Vasut
2013-12-11 4:37 ` Sourav Poddar
2013-12-11 4:19 ` Sourav Poddar
2013-12-11 4:18 ` Sourav Poddar
2013-12-11 10:44 ` Marek Vasut [this message]
2013-12-11 12:01 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201312111144.23012.marex@denx.de \
--to=marex@denx.de \
--cc=balbi@ti.com \
--cc=bcousson@baylibre.com \
--cc=broonie@kernel.org \
--cc=computersforpeace@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=dwmw2@infradead.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=sourav.poddar@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).