From: Huang Shijie <shijie8@gmail.com>
To: Caizhiyong <caizhiyong@hisilicon.com>
Cc: "Wanglin \(Albert\)" <albert.wanglin@hisilicon.com>,
David Woodhouse <David.Woodhouse@intel.com>,
Artem Bityutskiy <artem.bityutskiy@linux.intel.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Huang Shijie <b32955@freescale.com>,
Rashika Kheria <rashika.kheria@gmail.com>,
"linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>,
"Gupta, Pekon" <pekon@ti.com>,
Brian Norris <computersforpeace@gmail.com>,
David Woodhouse <dwmw2@infradead.org>
Subject: Re: [PATCH] mtd: nand: remove NAND_MAX_OOBSIZE and NAND_MAX_PAGESIZE
Date: Fri, 27 Dec 2013 23:07:24 +0800 [thread overview]
Message-ID: <20131227150721.GA1953@gmail.com> (raw)
In-Reply-To: <C3050A4DBA34F345975765E43127F10F25E480C3@SZXEMA512-MBX.china.huawei.com>
On Fri, Dec 27, 2013 at 01:03:32PM +0000, Caizhiyong wrote:
> From: Cai Zhiyong <caizhiyong@huawei.com>
> Date: Fri, 27 Dec 2013 20:23:09 +0800
> Subject: [PATCH] mtd: nand: remove NAND_MAX_OOBSIZE and NAND_MAX_PAGESIZE
>
> remove NAND_MAX_OOBSIZE and NAND_MAX_PAGESIZE, dynamic allocate
> NAND buffer after detecting NAND writesize and oobsize.
>
> - save memory. when use MACRO allocate static buffer, use a small
> page size NAND chip, the buffer is still 8k, the memory is wasted.
>
> - reduce maintenance. NAND chip pagesize and oobsize update frequently,
> allocate buffer according to the detecting size will reduce maintenance.
>
> - this fix was suggested by Brian Norris [computersforpeace@gmail.com]
> and Huang Shijie [b32955@freescale.com]
I have already sent out a patch set to remove these macros several days ago. :(
thanks
Huang Shijie
prev parent reply other threads:[~2013-12-27 15:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-27 13:03 [PATCH] mtd: nand: remove NAND_MAX_OOBSIZE and NAND_MAX_PAGESIZE Caizhiyong
2013-12-27 15:07 ` Huang Shijie [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131227150721.GA1953@gmail.com \
--to=shijie8@gmail.com \
--cc=David.Woodhouse@intel.com \
--cc=albert.wanglin@hisilicon.com \
--cc=artem.bityutskiy@linux.intel.com \
--cc=b32955@freescale.com \
--cc=caizhiyong@hisilicon.com \
--cc=computersforpeace@gmail.com \
--cc=dwmw2@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=pekon@ti.com \
--cc=rashika.kheria@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).