From: Brian Norris <computersforpeace@gmail.com>
To: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
Cc: linux-mtd@lists.infradead.org,
David Woodhouse <dwmw2@infradead.org>,
Artem Bityutskiy <dedekind1@gmail.com>
Subject: Re: [RFC/PATCH] mtd: Hide CONFIG_MTD_BLKDEVS from the menu
Date: Fri, 3 Jan 2014 11:48:01 -0800 [thread overview]
Message-ID: <20140103194801.GN5631@ld-irv-0074> (raw)
In-Reply-To: <20131220181757.GA17786@localhost>
On Fri, Dec 20, 2013 at 03:17:58PM -0300, Ezequiel Garcia wrote:
> On Thu, Dec 19, 2013 at 06:05:18PM -0800, Brian Norris wrote:
> > On Thu, Dec 19, 2013 at 09:47:13PM -0300, Ezequiel Garcia wrote:
> > > Any comments on this one?
> >
> > It looks OK to me. I might add a comment above MTD_BLKDEVS like I see in
> > some other similar Kconfig not-user-selectable options:
> >
> > #
> > # MTD block device support is select'ed if needed
> > #
> >
>
> Fully agreed.
Since I didn't receive a follow-up, I just added the comment and pushed
to l2-mtd.git. Diff pasted below.
Thanks,
Brian
diff --git a/drivers/mtd/Kconfig b/drivers/mtd/Kconfig
index 5fab4e6e8301..cdaa4e512c97 100644
--- a/drivers/mtd/Kconfig
+++ b/drivers/mtd/Kconfig
@@ -157,10 +157,11 @@ config MTD_BCM47XX_PARTS
comment "User Modules And Translation Layers"
+#
+# MTD block device support is select'ed if needed
+#
config MTD_BLKDEVS
- tristate "Common interface to block layer for MTD 'translation layers'"
- depends on BLOCK
- default n
+ bool
config MTD_BLOCK
tristate "Caching block device access to MTD devices"
next prev parent reply other threads:[~2014-01-03 19:48 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-13 13:58 [RFC/PATCH] mtd: Hide CONFIG_MTD_BLKDEVS from the menu Ezequiel Garcia
2013-12-20 0:47 ` Ezequiel Garcia
2013-12-20 2:05 ` Brian Norris
2013-12-20 18:17 ` Ezequiel Garcia
2014-01-03 19:48 ` Brian Norris [this message]
2014-01-05 8:46 ` Brian Norris
2014-01-05 17:37 ` Ezequiel Garcia
2014-01-05 22:06 ` Brian Norris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140103194801.GN5631@ld-irv-0074 \
--to=computersforpeace@gmail.com \
--cc=dedekind1@gmail.com \
--cc=dwmw2@infradead.org \
--cc=ezequiel.garcia@free-electrons.com \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox