From: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
To: Brian Norris <computersforpeace@gmail.com>
Cc: David Woodhouse <dwmw2@infradead.org>,
linux-mtd@lists.infradead.org,
Artem Bityutskiy <dedekind1@gmail.com>
Subject: Re: [RFC/PATCH] mtd: Hide CONFIG_MTD_BLKDEVS from the menu
Date: Sun, 5 Jan 2014 14:37:57 -0300 [thread overview]
Message-ID: <20140105173756.GA13922@localhost> (raw)
In-Reply-To: <20140105084547.GA2929@brian-ubuntu>
On Sun, Jan 05, 2014 at 12:46:10AM -0800, Brian Norris wrote:
>
> Hmm, I'm seeing some issues with this patch. I think it's problematic
> that you are changing MTD_BLKDEVS from tristate to bool. We can't have
[..]
>
> I believe the correct solution would be the following additional diff:
>
> diff --git a/drivers/mtd/Kconfig b/drivers/mtd/Kconfig
> index cdaa4e512c97..5ebcda39f554 100644
> --- a/drivers/mtd/Kconfig
> +++ b/drivers/mtd/Kconfig
> @@ -161,7 +161,7 @@ comment "User Modules And Translation Layers"
> # MTD block device support is select'ed if needed
> #
> config MTD_BLKDEVS
> - bool
> + tristate
>
> config MTD_BLOCK
> tristate "Caching block device access to MTD devices"
> --
>
> I'll squash this into your patch if I don't hear any objections.
>
The solution looks fine. Thanks for taking care of it.
--
Ezequiel García, Free Electrons
Embedded Linux, Kernel and Android Engineering
http://free-electrons.com
next prev parent reply other threads:[~2014-01-05 17:38 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-13 13:58 [RFC/PATCH] mtd: Hide CONFIG_MTD_BLKDEVS from the menu Ezequiel Garcia
2013-12-20 0:47 ` Ezequiel Garcia
2013-12-20 2:05 ` Brian Norris
2013-12-20 18:17 ` Ezequiel Garcia
2014-01-03 19:48 ` Brian Norris
2014-01-05 8:46 ` Brian Norris
2014-01-05 17:37 ` Ezequiel Garcia [this message]
2014-01-05 22:06 ` Brian Norris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140105173756.GA13922@localhost \
--to=ezequiel.garcia@free-electrons.com \
--cc=computersforpeace@gmail.com \
--cc=dedekind1@gmail.com \
--cc=dwmw2@infradead.org \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).