Re: [PATCH] mtd pxa3xx_nand.c: add support for 2048 bytes page size layout

[Ezequiel Garcia <ezequiel.garcia@free-electrons.com>]

Hi Rodolfo,

On Mon, Jan 13, 2014 at 03:35:38PM +0100, Rodolfo Giometti wrote:
> Signed-off-by: Rodolfo Giometti <giometti@linux.it>
> ---
>  drivers/mtd/nand/pxa3xx_nand.c | 21 +++++++++++++++++++++
>  1 file changed, 21 insertions(+)
> 

I know this is just a small nitpick, but can you re-submit this
with a subject similar to the other commits:

""mtd: nand: pxa3xx: Add support for 2048 bytes page size devices""

Also, I think you can add some details about the patch in the change
log. Something along these lines might be fine:

""
This commit adds support for devices with 2048B page sizes and
4-bit ECC strength requirements. This is achieved by enabling the BCH
ECC engine, which provides a higher strength: 16-bit over 2048 bytes.

Additionally, add a proper ECC layout to model the controller's view
of the device (where 'U' means unused and 'B' is the bad block marker):

 ----------------------------------------------------
 | 2048B data | B | B | 30B spare | 30B ECC | U | U |
 ----------------------------------------------------
""

With these modifications you can also add:

Acked-by: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>

Thanks a lot for the contribution!
-- 
Ezequiel García, Free Electrons
Embedded Linux, Kernel and Android Engineering
http://free-electrons.com