* [PATCH] mtd: m25p80: Use OPCODE_QUAD_READ_4B for 4-byte addressing
@ 2014-01-15 15:48 Geert Uytterhoeven
2014-01-16 0:09 ` Marek Vasut
0 siblings, 1 reply; 6+ messages in thread
From: Geert Uytterhoeven @ 2014-01-15 15:48 UTC (permalink / raw)
To: Brian Norris, Sourav Poddar, Marek Vasut, David Woodhouse
Cc: Geert Uytterhoeven, linux-mtd
From: Geert Uytterhoeven <geert+renesas@linux-m68k.org>
commit 3487a63955c34ea508bcf4ca5131ddd953876e2d ("drivers: mtd: m25p80: add
quad read support") in -next added both the 3-byte OPCODE_QUAD_READ and the
4-byte OPCODE_QUAD_READ_4B, but incorrectly uses OPCODE_QUAD_READ for both
3-byte and 4-byte addressing.
Use OPCODE_QUAD_READ_4B in the 4-byte case to fix this.
Signed-off-by: Geert Uytterhoeven <geert+renesas@linux-m68k.org>
---
drivers/mtd/devices/m25p80.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mtd/devices/m25p80.c b/drivers/mtd/devices/m25p80.c
index bf358326c335..0e9e78acc677 100644
--- a/drivers/mtd/devices/m25p80.c
+++ b/drivers/mtd/devices/m25p80.c
@@ -1258,7 +1258,7 @@ pr_info("jid = 0x%p\n", jid);
/* Dedicated 4-byte command set */
switch (flash->flash_read) {
case M25P80_QUAD:
- flash->read_opcode = OPCODE_QUAD_READ;
+ flash->read_opcode = OPCODE_QUAD_READ_4B;
break;
case M25P80_FAST:
flash->read_opcode = OPCODE_FAST_READ_4B;
--
1.7.9.5
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] mtd: m25p80: Use OPCODE_QUAD_READ_4B for 4-byte addressing
2014-01-15 15:48 [PATCH] mtd: m25p80: Use OPCODE_QUAD_READ_4B for 4-byte addressing Geert Uytterhoeven
@ 2014-01-16 0:09 ` Marek Vasut
2014-01-16 21:05 ` Brian Norris
0 siblings, 1 reply; 6+ messages in thread
From: Marek Vasut @ 2014-01-16 0:09 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: linux-mtd, Sourav Poddar, Brian Norris, David Woodhouse,
Geert Uytterhoeven
On Wednesday, January 15, 2014 at 04:48:55 PM, Geert Uytterhoeven wrote:
> From: Geert Uytterhoeven <geert+renesas@linux-m68k.org>
>
> commit 3487a63955c34ea508bcf4ca5131ddd953876e2d ("drivers: mtd: m25p80: add
> quad read support") in -next added both the 3-byte OPCODE_QUAD_READ and the
> 4-byte OPCODE_QUAD_READ_4B, but incorrectly uses OPCODE_QUAD_READ for both
> 3-byte and 4-byte addressing.
>
> Use OPCODE_QUAD_READ_4B in the 4-byte case to fix this.
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@linux-m68k.org>
Looks all right.
Acked-by: Marek Vasut <marex@denx.de>
> ---
> drivers/mtd/devices/m25p80.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mtd/devices/m25p80.c b/drivers/mtd/devices/m25p80.c
> index bf358326c335..0e9e78acc677 100644
> --- a/drivers/mtd/devices/m25p80.c
> +++ b/drivers/mtd/devices/m25p80.c
> @@ -1258,7 +1258,7 @@ pr_info("jid = 0x%p\n", jid);
> /* Dedicated 4-byte command set */
> switch (flash->flash_read) {
> case M25P80_QUAD:
> - flash->read_opcode = OPCODE_QUAD_READ;
> + flash->read_opcode = OPCODE_QUAD_READ_4B;
> break;
> case M25P80_FAST:
> flash->read_opcode = OPCODE_FAST_READ_4B;
Best regards,
Marek Vasut
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] mtd: m25p80: Use OPCODE_QUAD_READ_4B for 4-byte addressing
2014-01-16 0:09 ` Marek Vasut
@ 2014-01-16 21:05 ` Brian Norris
2014-01-17 2:04 ` Huang Shijie
0 siblings, 1 reply; 6+ messages in thread
From: Brian Norris @ 2014-01-16 21:05 UTC (permalink / raw)
To: Marek Vasut, Geert Uytterhoeven
Cc: David Woodhouse, Sourav Poddar, Geert Uytterhoeven,
Geert Uytterhoeven, linux-mtd
On Thu, Jan 16, 2014 at 01:09:34AM +0100, Marek Vasut wrote:
> On Wednesday, January 15, 2014 at 04:48:55 PM, Geert Uytterhoeven wrote:
> > From: Geert Uytterhoeven <geert+renesas@linux-m68k.org>
> >
> > commit 3487a63955c34ea508bcf4ca5131ddd953876e2d ("drivers: mtd: m25p80: add
> > quad read support") in -next added both the 3-byte OPCODE_QUAD_READ and the
> > 4-byte OPCODE_QUAD_READ_4B, but incorrectly uses OPCODE_QUAD_READ for both
> > 3-byte and 4-byte addressing.
> >
> > Use OPCODE_QUAD_READ_4B in the 4-byte case to fix this.
Wow, I noticed this and had a patch privately queued over a month ago
for this, but I forgot to send it out... Thanks for noticing!
> > Signed-off-by: Geert Uytterhoeven <geert+renesas@linux-m68k.org>
>
> Looks all right.
>
> Acked-by: Marek Vasut <marex@denx.de>
Pushed to l2-mtd.git.
Brian
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] mtd: m25p80: Use OPCODE_QUAD_READ_4B for 4-byte addressing
2014-01-16 21:05 ` Brian Norris
@ 2014-01-17 2:04 ` Huang Shijie
2014-01-17 7:01 ` Brian Norris
0 siblings, 1 reply; 6+ messages in thread
From: Huang Shijie @ 2014-01-17 2:04 UTC (permalink / raw)
To: Brian Norris
Cc: Marek Vasut, Geert Uytterhoeven, Geert Uytterhoeven, linux-mtd,
Sourav Poddar, David Woodhouse
On Thu, Jan 16, 2014 at 01:05:29PM -0800, Brian Norris wrote:
> On Thu, Jan 16, 2014 at 01:09:34AM +0100, Marek Vasut wrote:
> > On Wednesday, January 15, 2014 at 04:48:55 PM, Geert Uytterhoeven wrote:
> > > From: Geert Uytterhoeven <geert+renesas@linux-m68k.org>
> > >
> > > commit 3487a63955c34ea508bcf4ca5131ddd953876e2d ("drivers: mtd: m25p80: add
> > > quad read support") in -next added both the 3-byte OPCODE_QUAD_READ and the
> > > 4-byte OPCODE_QUAD_READ_4B, but incorrectly uses OPCODE_QUAD_READ for both
> > > 3-byte and 4-byte addressing.
> > >
> > > Use OPCODE_QUAD_READ_4B in the 4-byte case to fix this.
>
> Wow, I noticed this and had a patch privately queued over a month ago
> for this, but I forgot to send it out... Thanks for noticing!
>
> > > Signed-off-by: Geert Uytterhoeven <geert+renesas@linux-m68k.org>
> >
> > Looks all right.
> >
> > Acked-by: Marek Vasut <marex@denx.de>
>
> Pushed to l2-mtd.git.
this is a bad news to me. I have to send out a new version for the SPI NOR framework.
could this patch be merged after my spi-nor patch set? or create a new patch based
on the spi-nor framework.
thanks
Huang Shijie
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] mtd: m25p80: Use OPCODE_QUAD_READ_4B for 4-byte addressing
2014-01-17 2:04 ` Huang Shijie
@ 2014-01-17 7:01 ` Brian Norris
2014-01-18 21:20 ` Jagan Teki
0 siblings, 1 reply; 6+ messages in thread
From: Brian Norris @ 2014-01-17 7:01 UTC (permalink / raw)
To: Huang Shijie
Cc: Marek Vasut, Geert Uytterhoeven, Geert Uytterhoeven, linux-mtd,
Sourav Poddar, David Woodhouse
On Fri, Jan 17, 2014 at 10:04:54AM +0800, Huang Shijie wrote:
> On Thu, Jan 16, 2014 at 01:05:29PM -0800, Brian Norris wrote:
> > On Thu, Jan 16, 2014 at 01:09:34AM +0100, Marek Vasut wrote:
> > > On Wednesday, January 15, 2014 at 04:48:55 PM, Geert Uytterhoeven wrote:
> > > > From: Geert Uytterhoeven <geert+renesas@linux-m68k.org>
> > > >
> > > > commit 3487a63955c34ea508bcf4ca5131ddd953876e2d ("drivers: mtd: m25p80: add
> > > > quad read support") in -next added both the 3-byte OPCODE_QUAD_READ and the
> > > > 4-byte OPCODE_QUAD_READ_4B, but incorrectly uses OPCODE_QUAD_READ for both
> > > > 3-byte and 4-byte addressing.
> > > >
> > > > Use OPCODE_QUAD_READ_4B in the 4-byte case to fix this.
> >
> > Wow, I noticed this and had a patch privately queued over a month ago
> > for this, but I forgot to send it out... Thanks for noticing!
> >
> > > > Signed-off-by: Geert Uytterhoeven <geert+renesas@linux-m68k.org>
> > >
> > > Looks all right.
> > >
> > > Acked-by: Marek Vasut <marex@denx.de>
> >
> > Pushed to l2-mtd.git.
> this is a bad news to me. I have to send out a new version for the SPI NOR framework.
>
> could this patch be merged after my spi-nor patch set? or create a new patch based
> on the spi-nor framework.
This patch is a priority, since it's a bugfix to one that's already
queued up, so it must go first. I haven't taken a look at your latest
series, and I haven't seen comments lately. Was everyone happy with it?
If this conflict is the only problem, I'm sure that can be fixed
trivially. But I'm not sure if it's ready yet anyway. I won't be able to
get to it until next week (at the earliest).
Brian
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] mtd: m25p80: Use OPCODE_QUAD_READ_4B for 4-byte addressing
2014-01-17 7:01 ` Brian Norris
@ 2014-01-18 21:20 ` Jagan Teki
0 siblings, 0 replies; 6+ messages in thread
From: Jagan Teki @ 2014-01-18 21:20 UTC (permalink / raw)
To: Brian Norris
Cc: Marek Vasut, Geert Uytterhoeven, Huang Shijie, Geert Uytterhoeven,
linux-mtd, Sourav Poddar, David Woodhouse
On Fri, Jan 17, 2014 at 12:31 PM, Brian Norris
<computersforpeace@gmail.com> wrote:
> On Fri, Jan 17, 2014 at 10:04:54AM +0800, Huang Shijie wrote:
>> On Thu, Jan 16, 2014 at 01:05:29PM -0800, Brian Norris wrote:
>> > On Thu, Jan 16, 2014 at 01:09:34AM +0100, Marek Vasut wrote:
>> > > On Wednesday, January 15, 2014 at 04:48:55 PM, Geert Uytterhoeven wrote:
>> > > > From: Geert Uytterhoeven <geert+renesas@linux-m68k.org>
>> > > >
>> > > > commit 3487a63955c34ea508bcf4ca5131ddd953876e2d ("drivers: mtd: m25p80: add
>> > > > quad read support") in -next added both the 3-byte OPCODE_QUAD_READ and the
>> > > > 4-byte OPCODE_QUAD_READ_4B, but incorrectly uses OPCODE_QUAD_READ for both
>> > > > 3-byte and 4-byte addressing.
>> > > >
>> > > > Use OPCODE_QUAD_READ_4B in the 4-byte case to fix this.
>> >
>> > Wow, I noticed this and had a patch privately queued over a month ago
>> > for this, but I forgot to send it out... Thanks for noticing!
>> >
>> > > > Signed-off-by: Geert Uytterhoeven <geert+renesas@linux-m68k.org>
>> > >
>> > > Looks all right.
>> > >
>> > > Acked-by: Marek Vasut <marex@denx.de>
>> >
>> > Pushed to l2-mtd.git.
>> this is a bad news to me. I have to send out a new version for the SPI NOR framework.
>>
>> could this patch be merged after my spi-nor patch set? or create a new patch based
>> on the spi-nor framework.
>
> This patch is a priority, since it's a bugfix to one that's already
> queued up, so it must go first. I haven't taken a look at your latest
> series, and I haven't seen comments lately. Was everyone happy with it?
> If this conflict is the only problem, I'm sure that can be fixed
> trivially. But I'm not sure if it's ready yet anyway. I won't be able to
> get to it until next week (at the earliest).
I request all need to post the comments on this new framework, I have few points
which stops me to believe this is well written [1]
[1] http://www.spinics.net/lists/arm-kernel/msg301517.html
--
Thanks,
Jagan.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2014-01-18 21:20 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-01-15 15:48 [PATCH] mtd: m25p80: Use OPCODE_QUAD_READ_4B for 4-byte addressing Geert Uytterhoeven
2014-01-16 0:09 ` Marek Vasut
2014-01-16 21:05 ` Brian Norris
2014-01-17 2:04 ` Huang Shijie
2014-01-17 7:01 ` Brian Norris
2014-01-18 21:20 ` Jagan Teki
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).