Re: [PATCH] mtd: m25p80: assign default read command

Marek Vasut
2014-01-18T20:32:46Z

On Thursday, January 16, 2014 at 10:09:07 PM, Brian Norris wrote:
> In the following commit (in -next):
>
> commit 8552b439aba7f32063755d23f79ca27b4d0a3115
> drivers: mtd: m25p80: convert "bool" read check into an enum
>
> We converted the boolean 'fast_read' property to become an enum
> 'flash_read', but at the same time, we changed the conditional path so
> that it doesn't choose a default value in some cases (technically, we
> choose the correct default simply by virtue of devm_kzalloc(), which
> zeroes this out to be a NORMAL read operation, but still...).

Yep, that's true. It did default to the correct _NORMAL.

> Fix this by setting a default for the 'else' clause.
>
> Signed-off-by: Brian Norris <computersforpeace@gmail.com>
> Cc: Sourav Poddar <sourav.poddar@ti.com>

Let's be explicit indeed.

Acked-by: Marek Vasut <marex@denx.de>

Best regards,
Marek Vasut