From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oa0-x233.google.com ([2607:f8b0:4003:c02::233]) by merlin.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1W5Kvg-0002ZY-Kz for linux-mtd@lists.infradead.org; Mon, 20 Jan 2014 19:54:41 +0000 Received: by mail-oa0-f51.google.com with SMTP id h16so7656075oag.10 for ; Mon, 20 Jan 2014 11:54:19 -0800 (PST) Date: Mon, 20 Jan 2014 11:54:16 -0800 From: Brian Norris To: Prabhakar Lad Subject: Re: [PATCH] mtd: davinci_nand: Remove unnecessary labels from error path Message-ID: <20140120195416.GU8919@ld-irv-0074> References: <1389773306-7055-1-git-send-email-prabhakar.csengg@gmail.com> <20140116213206.GG8919@ld-irv-0074> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Cc: linux-mtd@lists.infradead.org, David Woodhouse , LKML List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Fri, Jan 17, 2014 at 01:20:36PM +0530, Prabhakar Lad wrote: > On Fri, Jan 17, 2014 at 10:46 AM, Prabhakar Lad > wrote: > > On Fri, Jan 17, 2014 at 3:02 AM, Brian Norris > > wrote: > >> On Wed, Jan 15, 2014 at 01:38:26PM +0530, Prabhakar Lad wrote: > >>> From: "Lad, Prabhakar" > >>> > >>> This patch removes the unnecessary labels from > >>> the error path in probe function which did nothing > >>> than just returning error values, Thus simplifying code > >>> path and improved readability. > >>> > >>> Signed-off-by: Lad, Prabhakar > >> > >> This does not apply to my branch, since some OOM messages have been > >> dropped. Can you rebase on l2-mtd.git (or linux-next)? > >> > > OK I'll rebase it against linux-next and post a v2. > > > My Bad was too late, there is already a patch fixing the above issue > in linux-next Ah, and my bad on remembering; I thought this looked familiar! :) > please ignore this patch. Sure. Thanks, Brian